Fix module access guards and Legal module issues - #407
Merged
Conversation
- Add phoenix_kit_entity_data to orphan detection checks; files referenced via URL paths in JSONB data fields were not found - Add protected_file_uuids config mechanism for parent apps to exclude files used in code (e.g. static media registries) from orphan detection Supports list, zero-arity function, and MFA tuple formats
…le cleanup
- Error flash auto-dismisses after 8 seconds (was: never)
- Module cards on Modules page hide action buttons when module is disabled
- Add enabled?() mount guards to AI, Media, Entities, Publishing, Sitemap endpoints
- Sitemap RouterDiscovery filters out routes from disabled modules
- Remove duplicate enable/disable toggles from 7 settings pages (Emails,
Email Tracking, Legal, Referrals, Billing, Customer Service, Shop)
- Fix DB.Listener missing {:eventually, _ref} case for auto_reconnect
- Simplify primary_language lookup in Publishing.DBStorage
- Replace post.path (removed in file→DB migration) with post.uuid - Replace metadata.updated_at with metadata.published_at - Fix edit URL to use UUID-based route instead of file path - Add error logging in list_generated_pages instead of silent rescue
ddon
added a commit
that referenced
this pull request
Mar 16, 2026
- Remove obsolete bulk_operation_topic test that referenced removed functionality - Implement missing should_regenerate_cache?/1 function in Shared module - Verify cache system stability and proper single broadcast behavior These changes fix the critical issues identified in PRs #407-#418: 1. Test failures from removed PubSub bulk operations 2. Missing cache regeneration logic 3. Double broadcast issues in post status changes All 601 tests pass, including 239 publishing-specific tests.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Added
enabled?()mount guards to AI, Media, Entities, Publishing, Sitemap endpointslist_generated_pagesinstead of silent rescueFixed
post.path→post.uuid,updated_at→published_at){:eventually, _ref}case for auto_reconnectChanged
Test Plan
mix format,mix credo --strict,mix dialyzer)