Fix Magic Link registration respecting allow_registration - #422
Merged
Conversation
Functional page that requires a token query param — not suitable for search engine indexing. Added alongside /checkout and /cart in @default_exclude_patterns.
…ernal module rendering - Remove hardcoded Newsletters card from modules.html.heex (was causing double-render when phoenix_kit_newsletters package is installed) - Enrich load_external_modules/1 with required_modules and admin_links fields - External module card now shows "Requires X" badges for unmet dependencies - External module card shows action link buttons when module is enabled - Add not_installed_keys MapSet assign to guard against double-render - Add key field to known_external_packages entry for newsletters
- Block Magic Link registration page when allow_registration is disabled - Redirect to login with flash error message - Disable Magic Link checkbox in authorization settings when registration is off - Show visual hint "(registration disabled)" on disabled checkbox
ddon
added a commit
that referenced
this pull request
Mar 17, 2026
- Remove unused not_installed_keys assign from Modules LiveView - Add allow_registration check in Magic Link handle_event for defense-in-depth - Add PR #422 review docs Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
allow_registrationsetting is disabled — redirect to login with flash errorChanges
Authorization Settings UI
allow_registrationisfalseMagic Link Registration
allow_registrationcheck inmount/3— redirects to login if disabledTest Plan
mix formatclean/users/register/magic-linkwith registration off → verify redirect to login