enable asset swap, IPFS, and related features for iOS builds#2045
Closed
Maxnflaxl wants to merge 3 commits into
Closed
enable asset swap, IPFS, and related features for iOS builds#2045Maxnflaxl wants to merge 3 commits into
Maxnflaxl wants to merge 3 commits into
Conversation
Without this, dex_board.cpp fails to compile because the BEAM_ASSET_SWAP_SUPPORT-guarded saveDexOffer/dropDexOffer declarations on IWalletDB are hidden in the cpp's translation unit even when the option is ON, since the macro never reaches wallet_core (and therefore its transitive consumers) on iOS.
Turn on BEAM_IPFS_SUPPORT for the iOS device and simulator workflow slices so libwallet_api.a / libwallet_client.a are built with ipfs_get / ipfs_add wired up (matching the desktop and Android builds instead of returning ApiError::NotSupported). Bump 3rdparty/asio-ipfs to the feat/ios-support tip (BeamMW/asio-ipfs#feat/ios-support), which adds CMAKE_SYSTEM_NAME=iOS cross-compilation paths for libipfs-bindings.a + libasio-ipfs.a. Without that submodule update the workflow flip would FATAL_ERROR at configure time on "Unsupported host platform iOS".
Maxnflaxl
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.