chore: upgrade @beesolve/lint-config to 0.3.0 (type-aware linting) - #10
Merged
Conversation
- add oxlint-tsgolint devDependency (new peer dep required by 0.3.0 for type-aware rules) - prefix intentional fire-and-forget calls with void to satisfy no-floating-promises (mock.module test setup, server.stop cleanup) Remaining oxlint warnings (no-unsafe-type-assertion on necessary casts, no-deprecated on required Context mock members) are config-level warnings and do not fail the build; left as-is per the lint-config author's intent.
- source: replace process.env casts with definedEnv() filter helper - handler.ts: narrow Context to omit deprecated done/fail/succeed - cdk.test.ts: use HttpMethod.ANY instead of "ANY" as never - bun handler.test.ts: drop redundant single-arm result assertions - node handler.test.ts: narrow v1|v2 result union via typed helpers - prefix intentional fire-and-forget calls with void (no-floating-promises) - scoped inline suppressions (with reasons) for genuine test-only assertions oxlint: 0 warnings / 0 errors; check, tsc, build, and tests all pass.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Supersedes #9 (dependabot's bare bump), doing the upgrade properly.
Summary
Upgrades
@beesolve/lint-config0.2.6→0.3.0, which enables oxlint type-aware linting and requires a new peer dependencyoxlint-tsgolint. Adds that dependency and resolves every finding the stricter rules surface — with real fixes where possible, scoped inline suppressions (with reasons) only for genuine test-only assertions.Changes
Dependencies
@beesolve/lint-config→0.3.0oxlint-tsgolint@^7.0.0(new required peer dep for type-aware rules)Real fixes (assertion removed, no suppression)
process.env as Record<string, string>with adefinedEnv()helper that filters outundefined(honest conversion, not a cast).test/cdk.test.ts: useHttpMethod.ANYinstead of"ANY" as never.files/bun/handler.test.ts: drop redundant single-arm result assertions (bun handler returns the type directly).files/node/handler.test.ts: narrow thev1 | v2handler-result union via small typedasV1Result/asV2Resulthelpers.files/*/handler.ts: narrowContextto omit the deprecateddone/fail/succeed(resolvesno-deprecated).mock.module,server.stop) withvoidforno-floating-promises.Scoped inline suppressions (test-only, with reasons)
util.test.ts:as nevercasts that deliberately exerciseassertUnreachable's runtime guard.files/*/stream.test.ts: stubbing theawslambdaruntime global with simplified fakes.test/integration/helpers.ts: typing a dynamicimport().Verification
oxlint: 0 warnings / 0 errorstsc --noEmit: cleanprepublishOnly): cleanbun test: 71 pass / 0 failIncludes a
patchchangeset (the shippeddist/files/**templates changed).