[4.x] refactor: Resolve small refactors & deprecations#1694
Merged
Conversation
acoulton
commented
Nov 19, 2025
Comment on lines
33
to
34
| private readonly ?JUnitDurationListener $durationListener = null, | ||
| private readonly ?ConfigurablePathPrinter $configurablePathPrinter = null, |
Contributor
Author
There was a problem hiding this comment.
These dependencies - and similar in a number of other classes - were added as nullable params to avoid a BC break for users creating our classes without using our service definitions. I think we should probably make them mandatory in 4.0, but I intend to handle that in a separate PR.
acoulton
commented
Nov 19, 2025
acoulton
force-pushed
the
4.x-remove-deprecations
branch
from
12e8dac to
00e9404
Compare
stof
reviewed
Nov 23, 2025
acoulton
force-pushed
the
4.x-remove-deprecations
branch
from
00e9404 to
fbee060
Compare
acoulton
force-pushed
the
4.x-remove-deprecations
branch
from
fbee060 to
44f9fa1
Compare
Deprecated and not updated since v3.13.0
These parameters are no longer used by our code, but were kept in the service definitions for BC for any end users who were providing their own implementations of these classes.
acoulton
force-pushed
the
4.x-remove-deprecations
branch
from
44f9fa1 to
241a0b7
Compare
4 tasks
Contributor
Author
|
The phpstan failure is also present in 4.x and will be fixed in a separate PR |
carlos-granados
approved these changes
Dec 4, 2025
carlos-granados
left a comment
carlos-granados
left a comment
Contributor
There was a problem hiding this comment.
Good job in the good direction 🎉
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves a number of deprecations and small refactors - generally around constructor signatures - that were identified in previous PRs and logged for the next major.
Partially addresses #1519