Skip to content

Remove orphan workers/dmc-properties/ — stop dmc-properties build failures on every push - #44

Merged
fsu9913-gif merged 1 commit into
mainfrom
cursor/stop-dmc-properties-build-noise-2917
Jun 29, 2026
Merged

Remove orphan workers/dmc-properties/ — stop dmc-properties build failures on every push#44
fsu9913-gif merged 1 commit into
mainfrom
cursor/stop-dmc-properties-build-noise-2917

Conversation

@CARBComplianceApp

Copy link
Copy Markdown
Contributor

What this fixes

The Cloudflare Workers Git integration has a dmc-properties project pointed at workers/dmc-properties/, which only ever contained rent-roll.html — no worker.js, no wrangler.toml, no package.json. Cloudflare can't build it, so every push triggers a failed deploy and posts a red ❌ status check on every PR.

Most recent example (raised by @cloudflare-workers-and-pages on PR #30):

❌ Deployment failed — dmc-properties — a173ce1b — May 13 2026, 02:25 AM

Build ac631182-e34e-418d-91ac-73a64e5cc8b2

That failure is on a now-merged PR (PR #30 was merged June 21 as 2f881af), but the root cause is still live on main and will keep firing.

Why it's safe to delete

The same rent-roll.html already exists at workers/portfolio-showcase/rent-roll.html — verified byte-for-byte identical:

$ diff -q workers/dmc-properties/rent-roll.html workers/portfolio-showcase/rent-roll.html
$ # (no output → files are identical)

The portfolio-showcase worker bundles its local copy via [[rules]] type = "Text" and serves it at showcase.silverbackai.agency/rent-ruby. The dmc-properties copy is pure dead weight.

An abandoned branch (claude/migrate-squarespace-cloudflare-gqs2e) already had this same removal as commit bf3db5e, but it was never merged. This PR revives that fix on a clean small diff off main.

Changes

  • Delete workers/dmc-properties/rent-roll.html (the only file in the folder; folder removed too).
  • Update CLAUDE.md architecture diagram + portfolio-showcase note so docs no longer reference a path that no longer exists.

One-time follow-up the repo cannot do

After this lands, the dmc-properties Cloudflare project should be deleted in the Cloudflare dashboard so its Git integration stops trying to build anything on every push. The integration is configured in the Cloudflare UI, not in this repo, so the repo PR alone can't remove it — but with no source files to build, even if the integration stays, it will at most fail on an obvious "no project found" rather than the misleading current "deployment failed" noise.

Testing

  • diff -q workers/dmc-properties/rent-roll.html workers/portfolio-showcase/rent-roll.html → no output (identical)
  • rg -n 'dmc-properties' . → no hits outside .git/ after the patch
  • cd workers/portfolio-showcase && npx wrangler@3 deploy --dry-runTotal Upload: 117.95 KiB / gzip: 27.68 KiB (still bundles the 90KB rent-roll.html — the /rent-ruby route is unaffected)
  • ls workers/ → 6 workers remain, dmc-properties is gone
Open in Web Open in Cursor 

…lures on every push

Cloudflare Workers Git integration has a 'dmc-properties' project
pointed at workers/dmc-properties/, which has only ever contained
rent-roll.html — no worker.js, no wrangler.toml, no package.json.
Cloudflare can't build it, so every push triggers a failed deploy
and posts a red ❌ comment on every PR (most recently noted on
PR #30: build ac631182-e34e-418d-91ac-73a64e5cc8b2 for commit
a173ce1).

The same rent-roll.html (byte-for-byte identical, verified with
`diff -q`) is already bundled and served by the portfolio-showcase
worker at showcase.silverbackai.agency/rent-ruby, via its
`[[rules]] type = 'Text'` import. The dmc-properties copy is pure
dead weight.

Changes:
  - Delete workers/dmc-properties/rent-roll.html (the only file
    in the folder; folder removed too).
  - Update CLAUDE.md architecture diagram + portfolio-showcase note
    so the docs no longer point at a path that doesn't exist.

After this lands, the dmc-properties Cloudflare project should be
deleted from the dashboard so the integration stops trying to build
anything. (One-time manual step — the Git integration is configured
in the Cloudflare UI, not in this repo.)

Verified:
  - rg -n 'dmc-properties' returns no hits outside .git/
  - portfolio-showcase still builds clean:
    npx wrangler@3 deploy --dry-run → Total Upload: 117.95 KiB
    (includes the 90KB rent-roll.html, served at /rent-ruby)

Note: an abandoned branch claude/migrate-squarespace-cloudflare-gqs2e
already had this same removal as commit bf3db5e, but it was never
merged. This commit revives that fix on a clean small PR off main.
@fsu9913-gif
fsu9913-gif marked this pull request as ready for review June 29, 2026 00:46
Copilot AI review requested due to automatic review settings June 29, 2026 00:46
@fsu9913-gif
fsu9913-gif merged commit 4801220 into main Jun 29, 2026
8 checks passed
@fsu9913-gif
fsu9913-gif deleted the cursor/stop-dmc-properties-build-noise-2917 branch June 29, 2026 00:47

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved. Cursor Bugbot was not present on this PR (signal skipped); CodeQL and Analyze checks passed. No additional reviewers assigned.

Open in Web View Automation 

Sent by Cursor Approval Agent: Pull Request Approver

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR removes the orphan workers/dmc-properties/ directory (which contained only a static rent-roll.html and no Worker entrypoint/config), eliminating a Cloudflare Git integration build target that can never successfully deploy and currently generates failing checks on pushes. It also updates CLAUDE.md so the repo architecture notes no longer reference the removed path and correctly describe where the rent roll is served from.

Changes:

  • Deleted workers/dmc-properties/rent-roll.html (and thus the now-empty workers/dmc-properties/ folder).
  • Updated CLAUDE.md architecture and “Key Patterns” notes to remove the dmc-properties reference and document that portfolio-showcase serves /rent-ruby from its local rent-roll.html.

Reviewed changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
workers/dmc-properties/rent-roll.html Removed dead static asset from an orphan Worker folder to prevent/avoid invalid build targets.
CLAUDE.md Updated architecture/pattern docs to reflect that the rent roll is bundled/served by portfolio-showcase, not dmc-properties.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants