Fix proxy vote receiver reload lifecycle#163
Merged
Merged
Conversation
BenCodez
marked this pull request as ready for review
July 24, 2026 01:36
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
testproxy subcommand while retainingvoteas a compatibility alias.Root cause
Proxy reload paths created a new
VoteReceiverwithout closing the current listener. The secondServerSocketbind therefore fails withBindException: Address already in use, leaving reload broken. The proxy command implementations also only recognizedvote, although the documented command istest;testwas silently ignored.Impact
Proxy administrators can reload VotifierPlus without leaking the listener, and
/votifierplus test <player> <service>now triggers a test vote on BungeeCord and Velocity.Validation
master.git diff --checkpassed.mvnis not installed.