Skip to content

Fix VoteStreak one-time rewards and legacy list migration#1509

Merged
BenCodez merged 1 commit intoBenCodez:masterfrom
semisolar:fix-votestreak-migration-recurring
May 2, 2026
Merged

Fix VoteStreak one-time rewards and legacy list migration#1509
BenCodez merged 1 commit intoBenCodez:masterfrom
semisolar:fix-votestreak-migration-recurring

Conversation

@semisolar
Copy link
Copy Markdown
Contributor

This builds on the legacy VoteStreak migration added in a74a7e3

Changes:

  • Makes Recurring: false reward only when streakCount == Requirements.Amount.
  • Keeps Recurring: true using the existing modulo behavior.
  • Preserves legacy list-based reward references during migration, for configs like:
Rewards:
- VoteSteak_3_Rewards_Online
- VoteSteak_3_Rewards_Offline
  • Adds tests for one-time vs recurring reward checks and list-based legacy reward migration.

@BenCodez BenCodez merged commit 35dc993 into BenCodez:master May 2, 2026
1 check passed
@semisolar semisolar deleted the fix-votestreak-migration-recurring branch May 2, 2026 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants