Make proxy cache vote deduplication atomic#1531
Merged
Merged
Conversation
BenCodez
marked this pull request as ready for review
July 19, 2026 19:46
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Why
The existing
contains-then-addflow was correct for sequential delivery but was not atomic. Two simultaneous deliveries with the samevoteIdcould both pass the duplicate check and be cached/persisted twice.Impact
Duplicate reservation is now atomic per
VoteCacheHandlerinstance. The synchronized sections are short and vote traffic is low-volume, so contention should be negligible.Validation
The new tests start two delivery threads behind a latch and assert that only one cache entry and one persistence call are produced for server and online caches.