Release 1.26.3 - #546
Merged
Merged
Conversation
The phases panel offered the SELECT action (and its 'Click to change' tooltip) based on island state and phase requirements alone, without checking whether the player actually holds the permission of the setcount command the click runs. A player with aoneblock.island.setcount negated saw the tooltip and then got a permission error when clicking. The panel now resolves the setcount subcommand and checks its permission before offering the action; if the command cannot be resolved it stays permissive and lets the command's own check decide. Same defect as BentoBoxWorld/ChunkBlock#11, whose panel code was copied from this one. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Y7xSdVPS5vRu6wqf6XshRq
…permission Only offer 'Click to change' in the phases GUI to players who can use it
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bug-fix release.
Fix:
/ob phasesoffered the "Click to change" tooltip regardless of whether the player held the permission of thesetcountcommand the click runs, so players withaoneblock.island.setcountnegated got a permission error on click. The panel now checks that permission before offering the action, and stays permissive if the subcommand cannot be resolved.What's Changed
Full Changelog: 1.26.2...1.26.3