fix: do not lose island progress when the server restarts

[tastybento]

The bug

Reported on Discord: a player breaks 30 blocks, the server restarts while they are still online, and they come back with those 30 blocks un-broken. Every restart, repeatedly.

The shutdown save was queued rather than written. AOneBlock.onDisable() called saveCache(), which uses saveObjectAsync(). This addon is a Pladdon, so the server disables it before BentoBox — the write went into a queue that BentoBox had to drain on its way out. BentoBox 3.22.0 added that drain (AbstractDatabaseHandler.flushAll()), but every earlier version discarded it silently. The reporter was on 3.15.0.

With the shutdown save lost, the count fell back to the last periodic checkpoint, which was a hardcoded every-50-blocks. Break fewer than 50 between restarts and nothing persists at all.

The fix

Write directly on shutdown. New BlockListener.saveCacheNow() using saveObjectNow(), called from onDisable(). This removes the dependency on core behaviour rather than relying on a particular BentoBox version getting it right. saveCache() is unchanged and still used for onReload(), where async is correct.

island.save-every, default 10 (was a hardcoded SAVE_EVERY = 50). Nothing helps if the server is SIGKILLed — there is no shutdown path to run — but this caps what an unclean kill can cost at 9 blocks instead of 49. getSaveEvery() clamps to ≥1 since it is a modulo divisor.

⚠️ Minimum BentoBox version is now 3.22.0

saveObjectNow() is 3.22.0 API, so bentobox.version is bumped and addon.yml api-version goes 3.13.0 → 3.22.0.

The api-version bump is required, not cosmetic. Without it the addon would still load on an older core and throw NoSuchMethodError at shutdown — worse than the bug being fixed. With it, BentoBox refuses to load the addon and says NOTE: Please update BentoBox.

Verification

Full suite: 560 tests, 0 failures.

Booted on two real servers:

• 1.21.11 / BentoBox 3.15.1 — refuses cleanly: Cannot load AOneBlock because it requires BentoBox version 3.22.0 or greater. No linkage error.
• 26.2 / BentoBox 3.22.1-SNAPSHOT — enables, all phases load, disables cleanly on SIGTERM with no errors. The log confirms the ordering in a live run: Disabling BentoBox-AOneBlock lands before BentoBox's own Disabling addons....

Scope caveat: neither server had a OneBlock island, so the boot test proves the addon loads, links and disables cleanly — it does not exercise a real block count surviving a restart. That path is covered by unit tests (saveCacheNow calls saveObjectNow and never saveObject; saveCache still queues).

Test fallout

The BentoBox bump broke 5 PhasesPanelTest tests, and fixing those exposed 2 more that were order-dependent. None were real regressions. All 7 called when(user.getTranslation(...)) on a real User (from User.getInstance(mockPlayer)), which stubs nothing on the User — Mockito attaches the stub to whichever mock the real method last touched. 3.22.0's getTranslation(World, ...) calls getIWM().getAddon(world) first, moving the target.

Added a stubTranslation() helper that stubs the LocalesManager these actually read from, and converted the 7.

Follow-up worth doing: roughly a dozen more when(user.getTranslation(...)) calls remain in that class, passing today by the same accident. They will break on some future BentoBox internal change.

🤖 Generated with Claude Code

https://claude.ai/code/session_014t1DSo2wMbTWZLcwXpwUmQ

[sonarqubecloud]

Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
71.4% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud