Fix SonarCloud: Production code quality improvements#2815
Merged
tastybento merged 3 commits intodevelopfrom Mar 3, 2026
Merged
Fix SonarCloud: Production code quality improvements#2815tastybento merged 3 commits intodevelopfrom
tastybento merged 3 commits intodevelopfrom
Conversation
- S4042: Replace File.delete() with Files.delete()/deleteIfExists() - S1871: Merge identical branches in EntityInteractListener, AdminPurgeRegionsCommand - S4738: Replace Guava ImmutableSet/ImmutableList with Java Set.copyOf/List.copyOf - S112: Replace generic RuntimeException with specific exceptions in GitHubWebAPI - S117/S100: Fix naming conventions in PhysicalInteractionListener, FlagListener - S3008/S116: Make RanksManager.ranks static final, use interface types - S4144: Extract shared helper methods in Island.java Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Resolve conflict in AdminPurgeRegionsCommand.java: keep Files.deleteIfExists() (S4042 fix) over old File.delete() pattern. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
File.delete()withFiles.delete()/Files.deleteIfExists()inAdminPurgeRegionsCommand(S4042)EntityInteractListener,Island,AdminPurgeRegionsCommand(S1871)ImmutableSetwithSet.copyOf()/Set.of()inSettings,Island(S4738)GitHubWebAPI(S112)PhysicalInteractionListener,FlagListener,PVPListener,InvincibleVisitorsListener,RanksManager(S116/S117/S100/S3008)Island.java(S4144)Risk
Medium — touches production logic, all affected tests verified.
Test plan
./gradlew clean testpasses🤖 Generated with Claude Code