Fix SonarCloud: Sealed classes, deprecated API, ChatColor removal#2816
Merged
tastybento merged 2 commits intodevelopfrom Mar 3, 2026
Merged
Fix SonarCloud: Sealed classes, deprecated API, ChatColor removal#2816tastybento merged 2 commits intodevelopfrom
tastybento merged 2 commits intodevelopfrom
Conversation
…duction code - Add null guard in IslandsManager.getIsland() for @nonnull params (S2637) - Add private constructor to UUIDFetcher utility class (S5993) - Apply sealed/final/non-sealed to AddonException, FlagChangeEvent, AddonBaseEvent, and AbstractTeleportListener hierarchies (S6355) - Add @SuppressWarnings for reflection in CommandsManager, FileLister, AddonsManager with justification comments (S3011) - Replace getDescription() with getPluginMeta() in 8 files (S1874) - Replace ChatColor with Adventure API in Util.java, CatalogPanel.java, and IslandSetnameCommand.java (~19 occurrences) Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
IslandsManager.getIsland()for@NonNullparams (S2637)UUIDFetcherutility class (S5993)sealed/final/non-sealedto 4 class hierarchies:AddonException,FlagChangeEvent,AddonBaseEvent,AbstractTeleportListener(S6355)@SuppressWarningsfor reflection inCommandsManager,FileLister,AddonsManagerwith justification comments (S3011)getDescription()withgetPluginMeta()in 8 files (S1874)ChatColorwith Adventure API / literal section-sign constants inUtil.java(~12 occurrences),CatalogPanel.java(~4),IslandSetnameCommand.java(~2)Risk
Medium-High — API changes, verify addon compatibility.
Test plan
./gradlew clean testpasses🤖 Generated with Claude Code