Fix SonarCloud: Replace deprecated EntityDamageByEntityEvent and LingeringPotion in tests#2817
Merged
tastybento merged 1 commit intodevelopfrom Mar 3, 2026
Merged
Conversation
…gPotion in PVPListenerTest Replace all 22 occurrences of the deprecated 6-arg EntityDamageByEntityEvent constructor (using DamageModifier, Guava Function/ImmutableMap) with the simpler 5-arg constructor via a new createDamageEvent helper method. Replace deprecated LingeringPotion.class mocks with ThrownPotion.class. Remove unused imports: EnumMap, DamageModifier, com.google.common.base.Function, Functions, ImmutableMap. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EntityDamageByEntityEventconstructors (usingDamageModifier, GuavaFunction/ImmutableMap) with simpler 5-arg constructor via a newcreateDamageEventhelper method inPVPListenerTestmock(LingeringPotion.class)withmock(ThrownPotion.class)Function,Functions,ImmutableMap,EnumMap,DamageModifierOther test files (
BreakBlocksListenerTest,HurtingListenerTest,ItemFrameListenerTest,TNTListenerTest) already use the non-deprecated constructors.Risk
Medium-High — test rewrite, must maintain coverage.
Test plan
./gradlew clean testpasses🤖 Generated with Claude Code