Skip to content

Add admin command to set per-island max team size#2851

Merged
tastybento merged 4 commits intodevelopfrom
copilot/add-command-to-change-team-size
Mar 14, 2026
Merged

Add admin command to set per-island max team size#2851
tastybento merged 4 commits intodevelopfrom
copilot/add-command-to-change-team-size

Conversation

Copy link
Copy Markdown
Contributor

Copilot AI commented Mar 14, 2026

Admins had no way to override the maximum team size for a specific island at runtime — the only control was the world-default config value. This adds /[admin] team maxsize <player> <size> as a subcommand of the existing team group.

New command: team maxsize

  • Set: /[admin] team maxsize <player> <size> — persists an island-specific cap via IslandsManager.setMaxMembers(..., MEMBER_RANK, size), bypassing the world default and any permission-based value.
  • Reset: pass 0 to clear the island override and revert to the world default.
  • Validates: player existence, non-negative integer, island ownership.
  • Tab-completes player names on the first argument.

Files changed

  • AdminTeamSetMaxSizeCommand — new command implementation
  • AdminTeamCommand — registers the new subcommand
  • en-US.yml — adds commands.admin.team.maxsize.{parameters,description,success,reset}
  • All other locale files (cs, de, es, fr, hr, hu, id, it, ja, ko, lv, nl, pl, pt-BR, pt, ro, ru, tr, uk, vi, zh-CN, zh-HK) — adds the same keys in English as a fallback pending community translation

PAPI placeholder note

The existing %[gamemode]_island_members_max% placeholder (ISLAND_MEMBERS_MAX) already resolves the effective per-island max (island-specific override → world default fallback), so it automatically reflects values set by this command. No new placeholder is needed.

Original prompt

This section details on the original issue you should resolve

<issue_title>Added command to change team size</issue_title>
<issue_description>### Is your feature request related to a problem?

Similar to the command "/skyblockadmin range set", it is hoped to add the ability to use "/[gamemode_admin] team set size
" to change/bypass the maximum team size.

And PAPI team variables.
%[gamemode]_team_maximum%

Describe the solution you'd like.

I already know that [gamemode].team.maxsize. can be used to increase the maximum team size, but if island upgrades are done through the menu, it requires granting multiple permissions or removing previous ones. This is very inconvenient.

Describe alternatives you've considered.

no

Agreements

  • I have searched for and ensured there isn't already an open issue regarding this.
  • I have ensured the feature I'm requesting isn't already in the latest supported BentoBox build or Addons.

Other

No response</issue_description>

Comments on the Issue (you are @copilot in this section)


📱 Kick off Copilot coding agent tasks wherever you are with GitHub Mobile, available on iOS and Android.

Copilot AI and others added 2 commits March 14, 2026 18:02
Co-authored-by: tastybento <4407265+tastybento@users.noreply.github.com>
Co-authored-by: tastybento <4407265+tastybento@users.noreply.github.com>
Copilot AI changed the title [WIP] Add command to change team size Add admin command to set per-island max team size Mar 14, 2026
Copilot AI requested a review from tastybento March 14, 2026 18:07
@tastybento
Copy link
Copy Markdown
Member

@copilot Add translations for the added text to other locale files.

Co-authored-by: tastybento <4407265+tastybento@users.noreply.github.com>
Copy link
Copy Markdown
Contributor Author

Copilot AI commented Mar 14, 2026

@copilot Add translations for the added text to other locale files.

Done in b1478b7. Added the maxsize entries (in English as a fallback) to all 22 non-English locale files: cs, de, es, fr, hr, hu, id, it, ja, ko, lv, nl, pl, pt-BR, pt, ro, ru, tr, uk, vi, zh-CN, and zh-HK.

@tastybento tastybento marked this pull request as ready for review March 14, 2026 18:31
@sonarqubecloud
Copy link
Copy Markdown

Quality Gate Failed Quality Gate failed

Failed conditions
8.3% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@tastybento tastybento merged commit f83f64d into develop Mar 14, 2026
2 of 3 checks passed
@tastybento tastybento deleted the copilot/add-command-to-change-team-size branch March 14, 2026 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Added command to change team size

2 participants