feat: add CraftEngineHook for centralised custom block support#2952
Merged
tastybento merged 1 commit intodevelopfrom Apr 21, 2026
Merged
feat: add CraftEngineHook for centralised custom block support#2952tastybento merged 1 commit intodevelopfrom
tastybento merged 1 commit intodevelopfrom
Conversation
Centralises CraftEngine custom block access in a BentoBox hook, following the same pattern as ItemsAdderHook and OraxenHook. Provides static utility methods for block ID detection, registry validation, and block placement so that addons do not need a direct CraftEngine compile-time dependency. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.



Summary
CraftEngineHookto the BentoBox hooks system, following the same pattern asItemsAdderHookandOraxenHookBentoBoxHookRegistrar.registerLateHooks()and addsCraftEnginetoplugin.ymlsoft-dependsnet.momirealms:craft-engine-bukkit/coreprovided compile dependencies and the MomiRealms Maven repoAPI provided
getBlockId(Location/Block)nullexists(String id)placeBlock(Location, String id)Context
CraftEngine support was added to AOneBlock in PR #496 using direct API calls. The Level addon (BentoBoxWorld/Level#418) also needs CraftEngine block detection for island level calculation. Centralising the hook in BentoBox means neither addon needs a direct CraftEngine compile dependency, and future addons get the same benefit for free.
Dependent PRs:
CraftEngineHook.getBlockId()Test plan
getHooks().getHook("CraftEngine").isPresent()returnstrueCraftEngineHook.getBlockId(location)returns the correct namespaced ID for a placed CE blockCraftEngineHook.placeBlock(location, id)places the block (exercised via AOneBlock)🤖 Generated with Claude Code