Improved CleanSuperFlat check#782
Merged
Poslovitch merged 3 commits intoBentoBoxWorld:developfrom Jun 23, 2019
YellowZaki:patch-6
Merged
Improved CleanSuperFlat check#782Poslovitch merged 3 commits intoBentoBoxWorld:developfrom YellowZaki:patch-6
Poslovitch merged 3 commits intoBentoBoxWorld:developfrom
YellowZaki:patch-6
Conversation
Poslovitch
added
Status: Need review
Poslovitch
requested changes
Jun 23, 2019
Member
Poslovitch
left a comment
Poslovitch
left a comment
There was a problem hiding this comment.
This conflicts with an already existing check.
However, the "inWorld" check can be added. I'll do that, then merge the PR.
Poslovitch
added
Status: Need revision
Poslovitch
approved these changes
Jun 23, 2019
Poslovitch
added
Status: Done
Poslovitch
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Today I found that BentoBox::Event: w.b.b.l.f.w.CleanSuperFlatListener (ChunkLoadEvent) was in the timings top and I didn't even have that flag enabled.
I went to the code and I found this...