feat: macos arm wheels #58
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
|
This looks awesome, thanks for the PR! Would you mind bumping the version in this PR, then I'll merge #59, cancel CI release run, then merge this? |
Collaborator
|
Sweet would you mind resolving the conflict and then we can get this released, thanks for the work on this! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This produces macos arm wheels in the github actions and upgrades the pypa/cibuildwheel to v2.12.0. Here's a test run of push.yml.
The wheel builder action warns that the arm builds aren't able to be tested yet, but it'll release in a future version. If this is a concern it can be added to the readme as a warning for macos arm users. Also, the warning can be disabled by adding
CIBW_TEST_SKIP: '*-macosx_arm64'to the env section of the pypa/cibuildwheel action.