Add excluded parts to parts tables#501
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
Adds support for excluding specific part numbers from parts-table-based selection blocks, enabling refinements (eg, filtering out out-of-stock parts) without changing the underlying parts tables.
Changes:
- Add an
excluded_partsinit argument toPartsTablePartand expose it as an argument parameter. - Include
excluded_partsas a generator dependency for parts-table selectors. - Update the base
_row_filterto exclude rows whose part number is inexcluded_parts.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+66
to
+68
| return (not self.get(self.part) or (self.get(self.part) == row[self.PART_NUMBER_COL])) and ( | ||
| not self.get(self.excluded_parts) or row[self.PART_NUMBER_COL] not in self.get(self.excluded_parts) | ||
| ) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds excluded_parts to all the base PartsTablePart.
This could be used, for example, in refinements to exclude parts that are out of stock.