Skip to content

Add GHA running manufacturing.sh#52

Merged
sdmurthy merged 2 commits into
BerkeleyLab:mainfrom
mdavidsaver:manu
Apr 7, 2025
Merged

Add GHA running manufacturing.sh#52
sdmurthy merged 2 commits into
BerkeleyLab:mainfrom
mdavidsaver:manu

Conversation

@mdavidsaver
Copy link
Copy Markdown
Contributor

Sets up environment, runs script, and does a cursory check that $PWD does not appear in the output.

@ldoolitt
Copy link
Copy Markdown
Collaborator

ldoolitt commented Apr 6, 2025

I like it!
I'm not an expert on GitHub Actions. I do see the log messages over at mdavidsaver. The zip-in-zip construction seems a bit odd.
I'm happy with the conversion to pip install kibom==1.9.1. As part of that, it looks like the message "KiBoM not found in \$PYTHONPATH" should be updated to "kibom not found in \$PATH".
It starts with runs-on: ubuntu-latest; are there not any Debian options? Oh, that's only the docker host, and the docker image is set to debian:12? OK, then.
In manufacturing.sh, can you sneak in an update to tested on Debian Bullseye 2024-03-20?

@mdavidsaver
Copy link
Copy Markdown
Contributor Author

tested on Debian Bullseye 2024-03-20

GHA will start building BerkeleyLab/Marble once a configuration appears on the default branch.

The zip-in-zip construction seems a bit odd.

This is a quirk of actions/upload-artifact.

should be updated to "kibom not found in \$PATH".

I was inconsistent. The entry point I use is python3 -m kibom which should work in all contexts (git clone, pypi install, ...)

the docker image is set to debian:12?

Correct. So the "host" image version should not matter.

can you sneak in an update to tested on Debian Bullseye 2024-03-20?

Done.

@sdmurthy sdmurthy merged commit 4e8cc50 into BerkeleyLab:main Apr 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants