Add assertions along all PRIF entry points that prif_init has been called#341
Merged
Conversation
…lled Many PRIF entry points begin with a call to internal helpers `team_check` or `coarray_handle_check`, so new assertions there cover a large fraction of the public entry points. The rest are covered by strategic insertion of assertions near the entry point. `prif_init_called_previously` is promoted to a module-level internal symbol to enable these assertions, and a new variable local to `prif_init` is used to detect potential discrepancies from memory corruption.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Many PRIF entry points begin with a call to internal helpers
team_checkorcoarray_handle_check, so new assertions there cover a large fraction of the public entry points.The rest are covered by strategic insertion of assertions near the entry point.
prif_init_called_previouslyis promoted to a module-level internal symbol to enable these assertions, and a new variable local toprif_initis used to detect potential discrepancies from memory corruption.