fix: shut down instance after workflow finishes#293
Closed
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #293 +/- ##
==========================================
+ Coverage 91.34% 91.36% +0.02%
==========================================
Files 54 54
Lines 13535 13540 +5
==========================================
+ Hits 12363 12371 +8
+ Misses 1172 1169 -3 |
Eric-Vin
approved these changes
Jul 17, 2024
4 tasks
Collaborator
|
Superseded by #310. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
As part of enhancing the simulator CI, we are introducing a condition for the
stop_ec2_instancestep that will get triggered regardless of success or failures of previous steps in the run to ensure that the instance is always stopped after a run.Issue Link
Checklist
pytestand/or other meansAdditional Notes