Skip to content

fix: shut down instance after workflow finishes#293

Closed
abanuelo wants to merge 9 commits intomainfrom
abanuelo/update-sim-workflow-to-shutdown
Closed

fix: shut down instance after workflow finishes#293
abanuelo wants to merge 9 commits intomainfrom
abanuelo/update-sim-workflow-to-shutdown

Conversation

@abanuelo
Copy link
Copy Markdown
Contributor

Description

As part of enhancing the simulator CI, we are introducing a condition for the stop_ec2_instance step that will get triggered regardless of success or failures of previous steps in the run to ensure that the instance is always stopped after a run.

Issue Link

Checklist

  • I have tested the changes locally via pytest and/or other means
  • I have added or updated relevant documentation
  • I have autoformatted the code with black and isort
  • I have added test cases (if applicable)

Additional Notes

@abanuelo abanuelo requested review from Eric-Vin and dfremont July 16, 2024 20:36
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 16, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.36%. Comparing base (f2c61b1) to head (537fa7a).
Report is 8 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main     #293      +/-   ##
==========================================
+ Coverage   91.34%   91.36%   +0.02%     
==========================================
  Files          54       54              
  Lines       13535    13540       +5     
==========================================
+ Hits        12363    12371       +8     
+ Misses       1172     1169       -3     

see 5 files with indirect coverage changes

@dfremont
Copy link
Copy Markdown
Collaborator

dfremont commented Nov 1, 2024

Superseded by #310.

@dfremont dfremont closed this Nov 1, 2024
@dfremont dfremont deleted the abanuelo/update-sim-workflow-to-shutdown branch April 8, 2025 22:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants