Conversation
…rts to stop the instance. Added if: always() so that stop_ec2_instance always runs even when test fail
…attatch to instance before starting instance
…napshot of volume, then deletes volume)
…pshot creation and resizing in AWS
- Added snapshot readiness check for volume creation - Enhanced logging for detailed instance state tracking - Extended timeout for instance status checks to 10 minutes
- Extended CARLA server connection attempt loop from 30 to 120 seconds. - Added pytest failure if unable to connect to CARLA within 2 minutes. - Increased CarlaSimulator communication timeout from 10 to 60 seconds.
… volume throughput to 250
…s to address connection stability
…vestigate instance stability and identify potential issues
… to 10s. No instance interruption this time.
…sure startup stability.
dfremont
reviewed
Oct 30, 2024
dfremont
reviewed
Oct 30, 2024
dfremont
requested changes
Oct 30, 2024
Collaborator
dfremont
left a comment
dfremont
left a comment
There was a problem hiding this comment.
Looks great, thanks Lola! Just a couple small suggestions above.
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #310 +/- ##
==========================================
- Coverage 91.37% 91.31% -0.07%
==========================================
Files 54 54
Lines 13544 13537 -7
==========================================
- Hits 12376 12361 -15
- Misses 1168 1176 +8 |
dfremont
approved these changes
Nov 1, 2024
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR updates the CI workflow for Scenic simulators to:
Create and attach a new gp3 volume from the latest snapshot during EC2 instance setup.
Prevent broken pipe errors during CARLA connection.
Ensure EC2 instance stops even if tests fail, and perform volume cleanup to avoid AWS costs.
Increase CARLA connection timeouts to ensure tests pass reliably.
Issue Link
This will resolve issue #293.
Checklist
pytestand/or other meansAdditional Notes
SCENIC-50