Various OpenDRIVE fixes#468
Open
dfremont wants to merge 6 commits into
Open
Conversation
* tolerate negative lane widths * tolerate zero-width portions of lanes (by eliding them) * only clean polygons if they are invalid * fix differencing of adjacent lane polygons
* skip spirals with very high curvature rates (which are probably artifacts) * simplify and improve code for skipping suspicious geometries * lane overlap removal shrinks the larger lane * fix combineSections logic for sidewalks/shoulders * tolerate linkage to junctions missing corresponding connections
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #468 +/- ##
==========================================
+ Coverage 89.70% 89.78% +0.07%
==========================================
Files 48 48
Lines 13287 13322 +35
==========================================
+ Hits 11919 11961 +42
+ Misses 1368 1361 -7
🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes various bugs with the OpenDRIVE parser and makes it more robust to some issues in maps we've been sent. In particular:
Thanks @Eric-Vin for independently fixing some of these bugs in #193.
Issue Link
Fixes #189. Fixes #274. Fixes #459.
Checklist
pytestand/or other means