feat(mcp): analytics MCP tools by jamby77 · Pull Request #331 · BetterDB-inc/monitor

jamby77 · 2026-07-22T08:50:31Z

Adds three read-only analytics MCP tools:

get_forecast — capacity forecast per metric kind (opsPerSec, usedMemory, cpuTotal, memFragmentation)
get_latency_regressions — persisted p99 latency-regression events (companion to get_anomalies, same store pre-filtered to command_p99), with a graceful note when BetterDB Pro is absent
get_largest_keys — largest keys by memory from key-analytics snapshots (companion to get_hot_keys), license-gated

Server side: new community McpAnalyticsController (forecast + latency regressions, optional anomaly-service injection) and a proprietary McpKeyAnalyticsController mirroring the cache-proposals MCP controller so the keyAnalytics license gate (402) actually runs; bundle-absent installs get a friendly client-side message instead of a raw 404.

Stacked on #330. Part of #329.

🤖 Generated with Claude Code

https://claude.ai/code/session_01BeJC3cWSEXFGD7MLMXaCiH

Note

Medium Risk
Changes MCP route ownership and license gating for anomalies/largest-keys, and alters anomaly and largest-key query semantics—worth validating against community vs Pro installs and existing MCP clients.

Overview
Adds read-only MCP analytics tools (get_forecast, get_latency_regressions, get_largest_keys) backed by new HTTP routes, and improves how missing Pro features show up in the client.

API / modules: Community McpAnalyticsController exposes GET …/forecast/:metricKind via MetricForecastingModule. Anomalies and largest-keys MCP endpoints move out of the monolithic McpController into proprietary McpAnomalyController (anomaly detection license + metricType validation) and McpKeyAnalyticsController (keyAnalytics license). createAgentTokenProviders centralizes cloud-mode agent token wiring across MCP-related modules; McpModule drops optional anomaly module import from the core controller.

Data behavior: getLargestKeys now ranks by memoryBytes (with multi-snapshot dedupe and a higher storage fetch cap before applying limit). AnomalyService.getRecentAnomalies unions persisted events with the in-memory cache for recent windows so storage-only events (e.g. command_p99) and cache-only failures both appear.

MCP client: HTTP errors carry status via ApiHttpError; 404 on gated/missing routes returns friendly unavailableResult text instead of a raw failure (anomalies, forecast, largest keys).

UI: Key Analytics “Largest Keys” copy clarifies memory-based ranking and tracking limits.

^{Reviewed by Cursor Bugbot for commit 6736dbf. Bugbot is set up for automated code reviews on this repo. Configure here.}

jamby77 · 2026-07-22T12:41:50Z

bugbot run

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit ade4490. Configure here.}

jamby77

Stack review, #331 layer: one licensing gap, two issues on the get_largest_keys tool contract, and a wiring duplication.

jamby77

One more from the stack review, on reuse.

jamby77 · 2026-07-23T07:34:53Z

bugbot run

cursor

✅ Bugbot reviewed your changes and found no new issues!

4 issues from previous reviews remain unresolved.

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit a36c4cd. Configure here.}

jamby77 · 2026-07-23T08:19:24Z

bugbot run

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit a36c4cd. Configure here.}

jamby77 · 2026-07-23T08:37:10Z

bugbot run

jamby77 · 2026-07-23T08:48:46Z

bugbot run

jamby77 · 2026-07-23T08:57:44Z

bugbot run

cursor

✅ Bugbot reviewed your changes and found no new issues!

1 issue from previous review remains unresolved.

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 6946a7c. Configure here.}

jamby77 · 2026-07-23T09:07:22Z

bugbot run

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit dee1143. Configure here.}

…text

… match

jamby77 · 2026-07-23T09:20:24Z

bugbot run

jamby77 · 2026-07-23T09:30:42Z

bugbot run

jamby77 · 2026-07-23T09:39:25Z

bugbot run

cursor

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

^{Reviewed by Cursor Bugbot for commit 6736dbf. Configure here.}

cursor Bot reviewed Jul 22, 2026

View reviewed changes

Comment thread packages/mcp/src/index.ts

jamby77 mentioned this pull request Jul 22, 2026

feat(mcp): vector search MCP tools #332

Open

jamby77 force-pushed the feature/329-mcp-analytics-tools branch from f8890e3 to ade4490 Compare July 22, 2026 12:39

cursor Bot reviewed Jul 22, 2026

View reviewed changes

jamby77 force-pushed the feature/329-mcp-analytics-tools branch from ade4490 to e8368e1 Compare July 22, 2026 12:45

jamby77 mentioned this pull request Jul 23, 2026

feat(mcp): AI observability MCP tools #330

Open

jamby77 commented Jul 23, 2026

View reviewed changes

Comment thread apps/api/src/mcp/mcp-analytics.controller.ts Outdated

Comment thread packages/mcp/src/index.ts Outdated

Comment thread packages/mcp/src/index.ts

Comment thread proprietary/key-analytics/key-analytics.module.ts Outdated

jamby77 commented Jul 23, 2026

View reviewed changes

Comment thread apps/api/src/mcp/mcp-analytics.controller.ts Outdated

jamby77 force-pushed the feature/329-mcp-analytics-tools branch from e8368e1 to 839748d Compare July 23, 2026 07:18

cursor Bot reviewed Jul 23, 2026

View reviewed changes

Comment thread proprietary/key-analytics/key-analytics.service.ts Outdated

Comment thread apps/api/src/mcp/mcp.module.ts

cursor Bot reviewed Jul 23, 2026

View reviewed changes

Comment thread proprietary/key-analytics/key-analytics.service.ts Outdated

Comment thread packages/mcp/src/index.ts

cursor Bot reviewed Jul 23, 2026

View reviewed changes

Comment thread proprietary/key-analytics/key-analytics.service.ts

cursor Bot reviewed Jul 23, 2026

View reviewed changes

Comment thread proprietary/key-analytics/key-analytics.service.ts

Comment thread proprietary/anomaly-detection/mcp-anomaly.controller.ts

jamby77 force-pushed the feature/329-mcp-analytics-tools branch from a36c4cd to f4daf18 Compare July 23, 2026 08:46

cursor Bot reviewed Jul 23, 2026

View reviewed changes

Comment thread proprietary/key-analytics/key-analytics.service.ts

cursor Bot reviewed Jul 23, 2026

View reviewed changes

Comment thread proprietary/key-analytics/mcp-key-analytics.controller.ts

cursor Bot reviewed Jul 23, 2026

View reviewed changes

Comment thread proprietary/anomaly-detection/anomaly.service.ts Outdated

cursor Bot reviewed Jul 23, 2026

View reviewed changes

jamby77 added 2 commits July 23, 2026 12:19

feat(mcp): add metric forecast endpoint

5dcbc7f

feat(mcp): add latency regressions endpoint over anomaly store

45cde19

jamby77 added 10 commits July 23, 2026 12:19

feat(mcp): add license-gated largest-keys endpoint

a9797f1

feat(mcp): add forecast, latency regression and largest keys tools

a39569a

fix(mcp): detect missing Pro bundle by 404 status instead of message …

2e4e7df

…text

fix(mcp): license-gate anomaly MCP routes, rank largest keys by memory

d5c29c0

fix(mcp): serve latency regressions via the anomalies route

c5cbb10

fix(mcp): cap ranked largest-keys fetch, renumber rank, drop dead wiring

290ea51

fix(mcp): dedupe repeated keys in time-range largest-keys ranking

3242845

fix(anomaly): fall through to storage when recent-window cache has no…

d13f841

… match

fix(web): describe largest keys as memory-ranked over tracked set

7d1ed93

fix(anomaly): union storage and cache for recent-window anomaly reads

c77f3ae

jamby77 force-pushed the feature/329-mcp-analytics-tools branch from dee1143 to c77f3ae Compare July 23, 2026 09:19

cursor Bot reviewed Jul 23, 2026

View reviewed changes

Comment thread proprietary/anomaly-detection/anomaly.service.ts

fix(anomaly): preserve connectionId when mapping stored events

006aa55

cursor Bot reviewed Jul 23, 2026

View reviewed changes

Comment thread packages/mcp/src/index.ts

fix(mcp): version-skew wording for community forecast 404

6736dbf

cursor Bot reviewed Jul 23, 2026

View reviewed changes

Uh oh!

Conversation

jamby77 commented Jul 22, 2026 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

jamby77 commented Jul 22, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

jamby77 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jamby77 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jamby77 commented Jul 23, 2026

Uh oh!

Uh oh!

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

jamby77 commented Jul 23, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

jamby77 commented Jul 23, 2026

Uh oh!

Uh oh!

Uh oh!

jamby77 commented Jul 23, 2026

Uh oh!

Uh oh!

Uh oh!

jamby77 commented Jul 23, 2026

Uh oh!

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

jamby77 commented Jul 23, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

jamby77 commented Jul 23, 2026

Uh oh!

Uh oh!

jamby77 commented Jul 23, 2026

Uh oh!

Uh oh!

jamby77 commented Jul 23, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

jamby77 commented Jul 22, 2026 •

edited by cursor Bot

Loading