feat(login): add SEO metadata via server-component layout - #32
Merged
Conversation
FrankezeCode
approved these changes
Aug 1, 2026
FrankezeCode
left a comment
Collaborator
There was a problem hiding this comment.
You did a great work here , thanks so much 👍
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds SEO metadata for the /login page so the browser tab shows a proper title and search engines get an accurate description.
The login page is a client component ( "use client" ), and Next.js forbids metadata exports from client components. Following the issue's suggested approach, I added a small server-component layout.tsx at src/app/login/ that exports:
This matches the existing pattern used on /meetup , /contact , and /careers . The login page itself is untouched, so the client-side session check and redirect-to-login flow work exactly as before.
Bonus fix: corrected two pre-existing react/no-unescaped-entities lint errors in src/app/meetup/[meetupId]/page.tsx (unescaped apostrophes). These were failing npm run build on main before any of my changes and blocked the "build passes" done-condition.
Related issue
Fixes #14
Type of change
How to test
Checklist
[x] I ran npm run build (and npm run contracts:test if contracts changed)
[x] I did not commit secrets or .env.local
[x] I read CONTRIBUTING.md