Add client info to clone NREPL request #2774
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for calva-docs ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
ericdallo
force-pushed
the
add-client-info-to-clone
branch
from
74cf585 to
45d8eb2
Compare
ericdallo
changed the title
ericdallo
force-pushed
the
add-client-info-to-clone
branch
from
45d8eb2 to
6a7bfbb
Compare
PEZ
reviewed
Apr 9, 2025
CHANGELOG.md
Outdated
|
|
||
| ## [Unreleased] | ||
|
|
||
| - [Add client info to nrepl clone request](https://github.com/BetterThanTomorrow/calva/pull/2774) |
Collaborator
There was a problem hiding this comment.
We want this to link to an issue which has the problem description. So that users curious about a change quickly can find out why it was made.
Collaborator
|
Now there are Prettier complaints and also you need to merge/rebase in latest |
Contributor
Author
|
Done @PEZ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What has changed?
As discussed here, we are adding nREPL client information to be able to provide metrics about the client of the nREPL.
Related to nrepl/nrepl#370
Fixes #2776
My Calva PR Checklist
I have:
devbranch. (Or have specific reasons to target some other branch.)published. (Sorry for the nagging.)[Unreleased]entry inCHANGELOG.md, linking the issue(s) that the PR is addressing.npm run prettier-format)npm run eslintbefore creating your PR, or runnpm run eslint-watchto eslint as you go).Ping @PEZ, @bpringe, @corasaurus-hex, @Cyrik