Skip to content

Remote kills are absolute#112

Merged
jmileham merged 2 commits into
Betterment:masterfrom
jmileham:remote_kills_are_absolute
Apr 17, 2019
Merged

Remote kills are absolute#112
jmileham merged 2 commits into
Betterment:masterfrom
jmileham:remote_kills_are_absolute

Conversation

@jmileham

Copy link
Copy Markdown
Member

Summary

This is a behavior change relative to #106 described here: #106 (comment)

Actual diff to follow...

/domain @Betterment/test_track_core
/platform @samandmoore @smudge

@nanda-prbot

Copy link
Copy Markdown

Needs somebody from @Betterment/test_track_core to claim domain review
Needs somebody from @samandmoore and @smudge to claim platform review

Use the shovel operator to claim, e.g.:

@myname << domain && platform

@jmileham

jmileham commented Apr 16, 2019

Copy link
Copy Markdown
Member Author

@jmileham
jmileham force-pushed the remote_kills_are_absolute branch 2 times, most recently from 4d412de to 74eae1a Compare April 16, 2019 14:07
@jmileham jmileham mentioned this pull request Apr 16, 2019
@jmileham
jmileham force-pushed the remote_kills_are_absolute branch from 74eae1a to d1904a3 Compare April 16, 2019 19:59
@samandmoore

Copy link
Copy Markdown
Member

<<domainlgtm platformlgtm

@nanda-prbot

Copy link
Copy Markdown

Approved! 👻 🎆 🎸

@jmileham
jmileham force-pushed the remote_kills_are_absolute branch 2 times, most recently from a81e83f to 8851323 Compare April 17, 2019 18:26
@jmileham
jmileham force-pushed the remote_kills_are_absolute branch from 8851323 to d5946de Compare April 17, 2019 18:30
@jmileham
jmileham merged commit 14a9c81 into Betterment:master Apr 17, 2019
@jmileham
jmileham deleted the remote_kills_are_absolute branch April 17, 2019 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants