Refactor Variant Detail presentation#47
Merged
agirlnamedsophia merged 3 commits intoApr 13, 2017
Merged
Conversation
|
Needs somebody from @Betterment/test_track_core to claim domain review. Use the shovel operator to claim, e.g.:
|
agirlnamedsophia
changed the title
Contributor
|
i thought there was a split presenter, or maybe variant presenter, spec that would need to be deleted? those three methods were covered somewhere. |
Contributor
Author
|
@dschaub you were right! i deleted them |
Contributor
|
we probably want those specs in variant_detail_spec now |
Contributor
Author
|
bump @dschaub |
Contributor
|
<< domain lgtm |
|
Ready to merge! ⛳ 🍔 💥 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
test_track_rails_clientwhere we were leaning on updated records to display variant_detaildisplay_names, though on the server we were lazily initializing them. The client would only displayvariant_detailsthat had been updated, so unless the data was updated manually the rows would be empty./domain @Betterment/test_track_core @dschaub