Skip to content

Fix Windows MSIX launch and English Plugins unlock#6

Merged
BigPizzaV3 merged 1 commit into
BigPizzaV3:mainfrom
MonsterQiu:fix/windows-msix-plugin-unlock
May 8, 2026
Merged

Fix Windows MSIX launch and English Plugins unlock#6
BigPizzaV3 merged 1 commit into
BigPizzaV3:mainfrom
MonsterQiu:fix/windows-msix-plugin-unlock

Conversation

@MonsterQiu

Copy link
Copy Markdown
Contributor

Summary

  • launch Windows Store/MSIX Codex installs through packaged app activation instead of direct WindowsApps executable startup
  • keep the existing direct executable path for macOS and unpackaged installs
  • unlock the plugin sidebar entry when the Codex UI label is English Plugins as well as Chinese 插件

Problem fixed

On Windows, Codex++ could silently fail when the shortcut used pythonw.exe because launching C:\Program Files\WindowsApps...\Codex.exe directly raised PermissionError: [WinError 5] Access is denied.

After launch was fixed, the plugin entry could still remain disabled for API key users because current Codex builds render the sidebar item as Plugins, while the injector only searched for 插件.

Verification

  • python -m pytest -q -> 63 passed

ode --check codex_session_delete\inject\renderer-inject.js

  • Manual Windows verification: Codex++ launched Codex on remote debugging port 9229, injected the helper, and enabled Plugins with auth method spoofed to chatgpt.

Windows Store/MSIX Codex installs live under WindowsApps, where direct CreateProcess calls can fail with WinError 5. Use the packaged app activation API for OpenAI.Codex packages while keeping the existing executable launch path for macOS and unpackaged installs.

The current Codex sidebar labels the plugin entry as Plugins, so the injector missed it when it only searched for the Chinese label. Match both labels so API key sessions can still trigger the existing auth-method spoof and enable the entry.

Constraint: WindowsApps packaged executables cannot be launched reliably through subprocess.Popen.

Rejected: Require users to run as administrator | does not address packaged app activation and is a worse user workflow.

Confidence: high

Scope-risk: moderate

Directive: Keep both packaged activation and direct executable launch paths; not every Codex install is MSIX packaged.

Tested: python -m pytest -q

Tested: node --check codex_session_delete\\inject\\renderer-inject.js

Tested: Manual Windows Codex++ launch opened Codex on 9229 and enabled Plugins with authMethod chatgpt.
@BigPizzaV3

Copy link
Copy Markdown
Owner

这是换了个启动方式吗,这样启动的时候能携带参数吗,测试了吗

@BigPizzaV3
BigPizzaV3 merged commit d2e4c0d into BigPizzaV3:main May 8, 2026
jarvislee90s-dot added a commit to jarvislee90s-dot/CodexPlusPlus-VsionForTextmodel that referenced this pull request Jul 17, 2026
…V3#3 + Minor BigPizzaV3#5/BigPizzaV3#6/BigPizzaV3#10)

Important:
- BigPizzaV3#1 i18n 契约:i18n-verify.mjs 扩展扫描 vlm-test-translation.ts 并识别 tr
  (1参->plain, 2参->template);补 7 个 pre-existing MISSING 英文译文。
  node tools/i18n-verify.mjs 全绿(plain 632/632, template 54/54)。
- BigPizzaV3#2 models_url 行为保持:剥离 /chat/completions 后保留原始 # 语义,
  避免 <origin>/chat/completions# 被误加 /v1。补 edge-case 测试锁定。
- BigPizzaV3#3 vlm-test-* CSS:补 modal/preview/description/detail/spinner 样式,
  预览图与长描述有尺寸约束。

Minor:
- BigPizzaV3#5 spinner:running 态加 CSS spinner。
- BigPizzaV3#6 截断:test_vlm_once 返回描述按 DESC_MAX_CHARS 截断。
- BigPizzaV3#10 parse_error 文案补「(单图测试不应触发)」尾巴。

BigPizzaV3#4(拖拽区)留 follow-up。
jarvislee90s-dot added a commit to jarvislee90s-dot/CodexPlusPlus-VsionForTextmodel that referenced this pull request Jul 17, 2026
…V3#3 + Minor BigPizzaV3#5/BigPizzaV3#6/BigPizzaV3#10)

Important:
- BigPizzaV3#1 i18n 契约:i18n-verify.mjs 扩展扫描 vlm-test-translation.ts 并识别 tr
  (1参->plain, 2参->template);补 7 个 pre-existing MISSING 英文译文。
  node tools/i18n-verify.mjs 全绿(plain 632/632, template 54/54)。
- BigPizzaV3#2 models_url 行为保持:剥离 /chat/completions 后保留原始 # 语义,
  避免 <origin>/chat/completions# 被误加 /v1。补 edge-case 测试锁定。
- BigPizzaV3#3 vlm-test-* CSS:补 modal/preview/description/detail/spinner 样式,
  预览图与长描述有尺寸约束。

Minor:
- BigPizzaV3#5 spinner:running 态加 CSS spinner。
- BigPizzaV3#6 截断:test_vlm_once 返回描述按 DESC_MAX_CHARS 截断。
- BigPizzaV3#10 parse_error 文案补「(单图测试不应触发)」尾巴。

BigPizzaV3#4(拖拽区)留 follow-up。
jarvislee90s-dot added a commit to jarvislee90s-dot/CodexPlusPlus-VsionForTextmodel that referenced this pull request Jul 21, 2026
…V3#3 + Minor BigPizzaV3#5/BigPizzaV3#6/BigPizzaV3#10)

Important:
- BigPizzaV3#1 i18n 契约:i18n-verify.mjs 扩展扫描 vlm-test-translation.ts 并识别 tr
  (1参->plain, 2参->template);补 7 个 pre-existing MISSING 英文译文。
  node tools/i18n-verify.mjs 全绿(plain 632/632, template 54/54)。
- BigPizzaV3#2 models_url 行为保持:剥离 /chat/completions 后保留原始 # 语义,
  避免 <origin>/chat/completions# 被误加 /v1。补 edge-case 测试锁定。
- BigPizzaV3#3 vlm-test-* CSS:补 modal/preview/description/detail/spinner 样式,
  预览图与长描述有尺寸约束。

Minor:
- BigPizzaV3#5 spinner:running 态加 CSS spinner。
- BigPizzaV3#6 截断:test_vlm_once 返回描述按 DESC_MAX_CHARS 截断。
- BigPizzaV3#10 parse_error 文案补「(单图测试不应触发)」尾巴。
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants