docs(ledger): record the post-merge verification of PR #2521 - #2565
Conversation
The prlanded review record this branch owed after its squash merge. The two-dot content diff between the squash commit 969cc7f and the branch tip 21f4ef3 was empty, so all fifteen commits landed and nothing was orphaned by the squash + auto-merge race that this record exists to catch. The ~20 inbox requests the branch carried are not applied here. PR #2559 rebased onto the squash and absorbed them, so #Z5P2BW, #0HYHTH and #AGRAKQ are archived there rather than twice; running a second reconciliation would have needed --allow-concurrent, which the guard for #EH9VA6 forbids. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01CQg8otWecCGsBJcLvkR7pm
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_45159f08-f91f-420e-a80c-e725355e3820) |
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 4c92c7e002
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| @@ -0,0 +1 @@ | |||
| | 2026-09-02 | claude/caring-contacts-vocabulary-tmnc89 | 969cc7f8889181758c93eb725e8eab7be6dc5e1e | prlanded | Merged and verified. Two-dot content diff between the squash commit and the branch tip 21f4ef3da was empty, so all fifteen commits landed and nothing was orphaned by the squash+auto-merge race. The ~20 queued inbox requests it carried are applied by PR #2559, which rebased onto this squash and absorbed them; #Z5P2BW, #0HYHTH and #AGRAKQ are archived there, and the two follow-ups this branch filed (#686WHW, #1NMMZS) are added. | prlanded content diff empty; full CI green on 21f4ef3da (PR required, Build, Unit coverage, Production UI 1/2/3 + critical, Caring Contacts database, Safety and config checks, Lighthouse, Static PR checks, PR policy, PR mergeability, Semgrep, Gitleaks, GitGuardian); one review thread, resolved | | |||
There was a problem hiding this comment.
If this immutable record is consulted before PR #2559 merges, it incorrectly reports that its issue changes “are applied” and that the named rows are archived or added. At this commit's parent, #Z5P2BW and #AGRAKQ remain open and #686WHW/#1NMMZS are absent, so the record is treating another PR's proposed diff as landed state; this can cause operators to skip the reconciliation that actually updates the canonical ledger. Describe these changes as queued in PR #2559 and record them as applied only after that PR lands.
AGENTS.md reference: AGENTS.md:L343-L343
Useful? React with 👍 / 👎.
PRs #2565 and #2566 each added a branch-review record, so merging main in left the generated index two records short. Regenerated with scripts/generate-branch-review-index.mjs. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Cq952TVk67XZzJnjiKt5pU
2 participants
Summary
docs/branch-review-records/23e5e883….record.md, recording the post-merge verification that PR Caring Contacts: extend the prohibited-language scan to the sealed domain, demo seed and API routes #2521's squash actually landed. Nothing else changes.Why this record exists at all. This repository squash-merges and auto-merges
claude/*branches on green, which has twice orphaned a late commit and once needed a fix-forward.prlandedcloses that hole by comparing content rather than ancestry, sincegit branch --mergedis meaningless after a squash rewrites history. The two-dot diff between the squash commit969cc7f88and the branch tip21f4ef3dawas empty, so all fifteen commits landed and nothing was lost to the race.The inbox requests are deliberately not applied here. #2521 carried around twenty queued ledger requests.
npm run issues:reconcilerefused to run them:That is PR #2559, and the guard is the one filed as
#EH9VA6— concurrent reconciliations corrupt the reconciliation journal. Overriding it with--allow-concurrentwould have been the wrong answer to a correct refusal. #2559 has since rebased onto969cc7f88and absorbed all of those requests itself, so#Z5P2BW,#0HYHTHand#AGRAKQare archived there, and the two follow-ups #2521 filed (#686WHW,#1NMMZS) are added there. Verified by reading its diff against the squash, not assumed. Applying them a second time here would have been a duplicate write to the same rows — exactly the failure#686WHWwas filed to describe.Verification
npm run verify:pr-localRun instead, as the gates that cover a single appended ledger record:
npm run check:branch-review-ledger—880 live table records + 1206 archived + 580 immutable (880 under the 2026-07-29 machine-readable contract), immutable review writes, six cells each, no conflict markers, mojibake, heading records, or duplicatesnpm run check:ledger-write-discipline—Ledger write discipline passed for 59b3490e37d4..HEADnpm run docs:check-links—docs link check passed: 4802 repo path references resolvenpm run check:outstanding-issues—[snapshot] in step with data/outstanding-issues-snapshot.json (70 open, 0 pending)npx prettier --checkon the new file —All matched files use Prettier code style!Verification not run:
verify:cheap,verify:ui,verify:release, lint, typecheck, build, tests. The diff is one new append-only Markdown record underdocs/branch-review-records/. No source, test, schema, workflow or configuration file is touched, so no executable behaviour has a changed failure path. Nothing provider-backed was run.The two
cancel request … did not take effectlines fromdocs:check-linksare pre-existing onmainand are warnings, not failures; the command exits 0.Risk and rollout
Notes
Recorded here rather than on #2521 because that pull request had already merged, and the record is by definition post-merge evidence.
The remote branch had been deleted by the auto-merge, so this push recreates it from the current
mainrather than continuing the merged history.--force-with-leasewas rejected for that reason (stale infoagainst a ref that no longer exists), and a plain push was the correct move; no history was rewritten.🤖 Generated with Claude Code
https://claude.ai/code/session_01CQg8otWecCGsBJcLvkR7pm
Generated by Claude Code
Note
Low Risk
Append-only documentation under docs/branch-review-records with no executable or production behavior.
Overview
Adds one append-only branch review ledger row at
docs/branch-review-records/23e5e883….record.mddocumenting that PR #2521 (claude/caring-contacts-vocabulary-tmnc89) squash-merged cleanly.The record marks status
prlandedwith evidence that the two-dot diff between squash969cc7f88and branch tip21f4ef3dawas empty (no orphaned commits after squash+auto-merge). It also notes that ~20 queued inbox reconciliations from that branch were not replayed here—PR #2559 absorbed them after rebasing onto the squash—and lists related issue IDs and CI/review outcomes.No application code, tests, config, or workflows change; this is immutable documentation only.
Reviewed by Cursor Bugbot for commit d7b17e2. Configure here.