docs: queue outstanding-issue for recurring shared-shell testid duplication - #2613
Conversation
…cation Playwright strict-mode "resolved to 2 elements" failures on service-actions-trigger (PR #2536) and sources-topics-main (PR #2591, tests/ui-sources.spec.ts:88) share the same shape: one element nested inside GlobalSearchShell's mobile-composer-reserve-pad wrapper, one outside it. Confirmed unrelated to either PR's own diff. Queuing for a focused investigation/fix rather than patching a "one owner" shared shell component inside an unrelated PR. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015uRvqm44emrLDMyPF7Pame
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Team Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
This pull request has been ignored for the connected project Preview Branches by Supabase. |
Same strict-mode "resolved to 2 elements" shape seen on PR #2613's queued issue, now also on caring-contacts-phone-dock (PR #2600). Three unrelated PRs, three different testids — updates the priority signal for the existing queued investigation without duplicating it. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015uRvqm44emrLDMyPF7Pame
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_e1082884-d487-4ce7-a52d-00c5d7afb03b) |
The earlier note claimed the duplicate caring-contacts-phone-dock element was nested inside mobile-composer-reserve-pad by analogy with the first two occurrences. The actual job log for this instance only shows two sibling matches for the same testid; the nesting detail was not verified and is removed. Cancels and replaces the prior entry. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_015uRvqm44emrLDMyPF7Pame
…to claude/pr-2591-review-dd12b1
Bugbot couldn't run - usage limit reachedBugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit. A user or team admin can review and increase usage limits in the Cursor dashboard. (requestId: serverGenReqId_bb255578-18cc-44d3-8793-94166592b392) |
Summary
npm run issues:add, merge-safe, applied later vianpm run issues:reconcile) documenting a recurring Playwright strict-mode failure.Why
While driving PR #2591 and PR #2548 to green, the same CI failure shape turned up twice on unrelated tests:
service-actions-trigger(documented precedent on PR Age medication source status on the read path and make unknown visible #2536)sources-topics-main(tests/ui-sources.spec.ts:88, seen on PR Add searchable grouped mode picker #2591 run 33868983554)Both are
getByTestId(...).toBeVisible()strict-mode violations resolving to 2 elements — one nested insideGlobalSearchShell'smobile-composer-reserve-padwrapper, one outside it. Confirmed unrelated to either PR's own diff (neither touchesglobal-search-shell.tsx,sources-browse-client.tsx, ormode-home-template.tsx).GlobalSearchShellis a "one owner" contract component (AGENTS.md"Search chrome behaviour"), so a real fix needsdocs/search-chrome-behaviour.mdread first, root-cause isolation, and its own focused PR plusnpm run verify:phone-chrome— not a patch riding an unrelated PR. This queues that as tracked follow-up work instead.Verification
npx prettier --check docs/outstanding-issues-inbox/4cc4b95c-8dcb-4772-a157-b7ae2980c033.json— passed.node scripts/ledger-inbox.mjs check—Ledger inbox check passed: 62 pending request(s), 944 applied.verify:pr-local/ full test suite — docs-only, append-only ledger change; GitHub CI is the requested broad verification surface.Risk and rollout
npm run issues:reconcilerun.Clinical Governance Preflight
Not applicable: documentation/ledger-only change, no code, retrieval, ingestion, or clinical-output surface touched.
🤖 Generated with Claude Code
https://claude.ai/code/session_015uRvqm44emrLDMyPF7Pame
Generated by Claude Code
Note
Low Risk
Append-only documentation/ledger inbox entries with no runtime, provider, or production impact.
Overview
This PR only updates the outstanding-issues inbox (merge-safe JSON; applied later via
issues:reconcile)—no application code.It queues a P2 issue for recurring Playwright strict-mode failures where
getByTestIdmatches two elements (service-actions-trigger,sources-topics-main), including the verified pattern of one copy insideGlobalSearchShell'smobile-composer-reserve-padand one outside, with follow-up called out per search-chrome contract docs.It also logs a third occurrence on
caring-contacts-phone-dock(Caring Contacts workspace, unrelated PR #2600). An initial inbox add that implied the same nesting as the first two cases is cancelled and replaced with wording that only states two sibling matches—nesting for that run was not verified—while still treating three unrelated PRs/testids as evidence of a systemic layout-duplication problem.Reviewed by Cursor Bugbot for commit 876ec76. Configure here.