Skip to content

docs: queue outstanding-issue for recurring shared-shell testid duplication - #2613

Merged
BigSimmo merged 11 commits into
mainfrom
claude/pr-2591-review-dd12b1
Sep 4, 2026
Merged

docs: queue outstanding-issue for recurring shared-shell testid duplication#2613
BigSimmo merged 11 commits into
mainfrom
claude/pr-2591-review-dd12b1

Conversation

@BigSimmo

@BigSimmo BigSimmo commented Sep 4, 2026

Copy link
Copy Markdown
Owner

Summary

  • Queues one outstanding-issue inbox entry (npm run issues:add, merge-safe, applied later via npm run issues:reconcile) documenting a recurring Playwright strict-mode failure.
  • No source code changes.

Why

While driving PR #2591 and PR #2548 to green, the same CI failure shape turned up twice on unrelated tests:

Both are getByTestId(...).toBeVisible() strict-mode violations resolving to 2 elements — one nested inside GlobalSearchShell's mobile-composer-reserve-pad wrapper, one outside it. Confirmed unrelated to either PR's own diff (neither touches global-search-shell.tsx, sources-browse-client.tsx, or mode-home-template.tsx).

GlobalSearchShell is a "one owner" contract component (AGENTS.md "Search chrome behaviour"), so a real fix needs docs/search-chrome-behaviour.md read first, root-cause isolation, and its own focused PR plus npm run verify:phone-chrome — not a patch riding an unrelated PR. This queues that as tracked follow-up work instead.

Verification

  • npx prettier --check docs/outstanding-issues-inbox/4cc4b95c-8dcb-4772-a157-b7ae2980c033.json — passed.
  • node scripts/ledger-inbox.mjs checkLedger inbox check passed: 62 pending request(s), 944 applied.
  • Not run: verify:pr-local / full test suite — docs-only, append-only ledger change; GitHub CI is the requested broad verification surface.

Risk and rollout

  • Risk: none — adds one JSON file to the outstanding-issues inbox, applied to the canonical ledger only by a separate, serialized npm run issues:reconcile run.
  • Rollback: revert the commit.
  • Provider or production effects: none.
  • RAG impact: none.

Clinical Governance Preflight

Not applicable: documentation/ledger-only change, no code, retrieval, ingestion, or clinical-output surface touched.

🤖 Generated with Claude Code

https://claude.ai/code/session_015uRvqm44emrLDMyPF7Pame


Generated by Claude Code


Note

Low Risk
Append-only documentation/ledger inbox entries with no runtime, provider, or production impact.

Overview
This PR only updates the outstanding-issues inbox (merge-safe JSON; applied later via issues:reconcile)—no application code.

It queues a P2 issue for recurring Playwright strict-mode failures where getByTestId matches two elements (service-actions-trigger, sources-topics-main), including the verified pattern of one copy inside GlobalSearchShell's mobile-composer-reserve-pad and one outside, with follow-up called out per search-chrome contract docs.

It also logs a third occurrence on caring-contacts-phone-dock (Caring Contacts workspace, unrelated PR #2600). An initial inbox add that implied the same nesting as the first two cases is cancelled and replaced with wording that only states two sibling matches—nesting for that run was not verified—while still treating three unrelated PRs/testids as evidence of a systemic layout-duplication problem.

Reviewed by Cursor Bugbot for commit 876ec76. Configure here.

…cation

Playwright strict-mode "resolved to 2 elements" failures on
service-actions-trigger (PR #2536) and sources-topics-main (PR #2591,
tests/ui-sources.spec.ts:88) share the same shape: one element nested
inside GlobalSearchShell's mobile-composer-reserve-pad wrapper, one
outside it. Confirmed unrelated to either PR's own diff. Queuing for a
focused investigation/fix rather than patching a "one owner" shared
shell component inside an unrelated PR.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015uRvqm44emrLDMyPF7Pame
@coderabbitai

coderabbitai Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Important

  • 🔍 Trigger review

This repository does not receive automatic reviews because it has fewer than 10 stars.

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Team

Run ID: 4eaadbd8-633f-41f4-96d8-e6a3e85effe6


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@supabase

supabase Bot commented Sep 4, 2026

Copy link
Copy Markdown

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.


Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

Same strict-mode "resolved to 2 elements" shape seen on PR #2613's
queued issue, now also on caring-contacts-phone-dock (PR #2600).
Three unrelated PRs, three different testids — updates the priority
signal for the existing queued investigation without duplicating it.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015uRvqm44emrLDMyPF7Pame
@BigSimmo
BigSimmo marked this pull request as ready for review September 4, 2026 12:48
@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, add credits to your account and enable them for code reviews in your settings.

@cursor

cursor Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_e1082884-d487-4ce7-a52d-00c5d7afb03b)

claude and others added 6 commits September 4, 2026 12:50
The earlier note claimed the duplicate caring-contacts-phone-dock
element was nested inside mobile-composer-reserve-pad by analogy with
the first two occurrences. The actual job log for this instance only
shows two sibling matches for the same testid; the nesting detail was
not verified and is removed. Cancels and replaces the prior entry.

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_015uRvqm44emrLDMyPF7Pame
@cursor

cursor Bot commented Sep 4, 2026

Copy link
Copy Markdown
Contributor

Bugbot couldn't run - usage limit reached

Bugbot is counted against Cursor usage for this user or team, and this run hit a usage or spend limit.

A user or team admin can review and increase usage limits in the Cursor dashboard.

(requestId: serverGenReqId_bb255578-18cc-44d3-8793-94166592b392)

@BigSimmo
BigSimmo enabled auto-merge (squash) September 4, 2026 16:15
@BigSimmo
BigSimmo merged commit 9ca3b4e into main Sep 4, 2026
27 checks passed
@BigSimmo
BigSimmo deleted the claude/pr-2591-review-dd12b1 branch September 4, 2026 16:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants