fix: keep Actions pull request creation enabled - #64
Merged
Conversation
The workflow-permissions flag named can_approve_pull_request_reviews governs the combined "create and approve pull requests" permission. Setting it to false broke the watcher's daily evidence-record PR and the mise-php consumer's readiness PRs after the configure script was re-run during the ruleset migration. Approvals stay owner-only via the ruleset and protected controls.
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
📝 WalkthroughWalkthroughThe autorelease workflow now enables pull-request review approval. The admin-state snapshot records the updated permission, timestamp, and digest. ChangesAutorelease permission update
Estimated code review effort: 2 (Simple) | ~10 minutes Possibly related PRs
🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches🧪 Generate unit tests (beta)
Comment |
This was referenced Aug 5, 2026
loadinglucian
added a commit
to Bigpixelrocket/mise-php
that referenced
this pull request
Aug 5, 2026
## Summary Companion to Bigpixelrocket/php-bin#64. The workflow-permissions flag `can_approve_pull_request_reviews` governs the combined "create and approve pull requests" GitHub setting, and the autorelease consumer's readiness PRs require it. Re-running the configure script during the ruleset migration switched it off in both repos, which broke php-bin's watcher this morning and would have broken the next consumer run that needed to write a readiness record. ## Changes - `docs/admin-state/mise-php-after.json`: regenerated with php-bin's `scripts/snapshot-github-admin-state` after restoring the live setting on this repo. The configure-script fix itself lives in php-bin, which owns that script. <!-- This is an auto-generated comment: release notes by coderabbit.ai --> ## Summary by CodeRabbit - **Chores** - Updated workflow permissions to support approving pull request reviews. - Refreshed administrative state records and associated metadata to reflect the latest configuration. <!-- end of auto-generated comment: release notes by coderabbit.ai -->
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The watcher failed this morning (run 30987026534, issue #63) because it could not open its daily evidence-record PR:
GitHub Actions is not permitted to create or approve pull requests.Root cause:
scripts/configure-github-autoreleasesets the workflow-permissions flagcan_approve_pull_request_reviewstofalse. Despite its name, that flag governs the combined GitHub setting "Allow GitHub Actions to create and approve pull requests", so re-running the configure script during the ruleset migration (#61) switched off PR creation forGITHUB_TOKENin both repos. The watcher's evidence-record PRs and the mise-php consumer's readiness PRs both depend on it, as documented indocs/repository-settings.md("Keep the default Actions token read-only while enabling automation PR creation").Changes
scripts/configure-github-autorelease: set the flag totruewith a comment explaining that it also governs PR creation. Approvals remain owner-only through the ruleset and protected controls, and runtime workflows never submit approving reviews.docs/admin-state/php-bin-after.json: regenerated withscripts/snapshot-github-admin-stateafter restoring the live setting.The live setting has already been restored on both repos; a companion PR updates the mise-php snapshot.
Summary by CodeRabbit