Skip to content

fix: disable webhooks when setting transaction category - #1

Merged
Billos merged 3 commits into
mainfrom
copilot/fix-transaction-category-webhooks
Jan 6, 2026
Merged

fix: disable webhooks when setting transaction category#1
Billos merged 3 commits into
mainfrom
copilot/fix-transaction-category-webhooks

Conversation

Copilot AI commented Jan 6, 2026

Copy link
Copy Markdown
Contributor

Setting a transaction category via the UI endpoint was firing webhooks, causing the transaction to be reprocessed and notifications to be re-sent.

Changes

  • Set fire_webhooks: false in settingCategoryForTransaction.ts when updating transactions
await TransactionsService.updateTransaction(transactionId, {
  apply_rules: true,
  fire_webhooks: false,  // Changed from true
  transactions: [{ category_id }],
})

This aligns with the pattern used elsewhere in the codebase (e.g., transactionHandler.ts, linkPaypalTransactions.ts) where internal transaction updates don't re-trigger webhook processing.

Note

The settingBudgetForTransaction.ts endpoint has the same pattern but was not modified per the issue scope.

Original prompt

setting the category of a transaction should not fire the webhooks


✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.

@coderabbitai

coderabbitai Bot commented Jan 6, 2026

Copy link
Copy Markdown

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.


Comment @coderabbitai help to get the list of available commands and usage tips.

Copilot AI and others added 2 commits January 6, 2026 10:21
Co-authored-by: Billos <5809662+Billos@users.noreply.github.com>
Changed fire_webhooks from true to false in settingCategoryForTransaction endpoint to prevent infinite loops and unwanted webhook triggers when manually setting categories through the UI.

Co-authored-by: Billos <5809662+Billos@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix webhook trigger for setting transaction category fix: disable webhooks when setting transaction category Jan 6, 2026
Copilot AI requested a review from Billos January 6, 2026 10:25
@Billos
Billos marked this pull request as ready for review January 6, 2026 15:16
@Billos
Billos merged commit 8b14244 into main Jan 6, 2026
1 check passed
@Billos
Billos deleted the copilot/fix-transaction-category-webhooks branch January 8, 2026 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants