Skip to content

Comments

Added Guidance2 to containers#242

Merged
osallou merged 5 commits intoBioContainers:masterfrom
Nesh108:master
Jun 29, 2018
Merged

Added Guidance2 to containers#242
osallou merged 5 commits intoBioContainers:masterfrom
Nesh108:master

Conversation

@Nesh108
Copy link
Contributor

@Nesh108 Nesh108 commented Jun 27, 2018

Hello,

Added Guidance2 container as per request: #158
Looked through the homepage of the project but couldn't find any specific license for it.

Cheers!

@osallou
Copy link
Contributor

osallou commented Jun 27, 2018

please specify in about.license_file the location of the license file in the container, or a url to license for this release of the software.

@osallou
Copy link
Contributor

osallou commented Jun 27, 2018

about.license field is not in spdx list: https://spdx.org/licenses/, if it is a typo error, please fix it. If this is not a standard license, then ignore this message.

@osallou
Copy link
Contributor

osallou commented Jun 27, 2018

Found a biotools entry matching the software name (https://bio.tools/guidance2), if this is the same software, please add the extra.identifier.biotools label to your Dockerfile

@osallou
Copy link
Contributor

osallou commented Jun 27, 2018

about.license field is not in spdx list: https://spdx.org/licenses/, if it is a typo error, please fix it. If this is not a standard license, then ignore this message.

@osallou
Copy link
Contributor

osallou commented Jun 27, 2018

As specified in failure build messahe, base_image is missing in labels

@osallou
Copy link
Contributor

osallou commented Jun 29, 2018

No guidance2/2.02/test-cmds.txt (test file) present, skipping tests

@osallou
Copy link
Contributor

osallou commented Jun 29, 2018

hi, for biotools label:

extra.identifier.biotools="https://bio.tools/guidance2"

should be

extra.identifier.biotools="guidance2"

will merge after modification, thanks

@osallou
Copy link
Contributor

osallou commented Jun 29, 2018

No guidance2/2.02/test-cmds.txt (test file) present, skipping tests

@osallou osallou merged commit 81a9bd6 into BioContainers:master Jun 29, 2018
@osallou
Copy link
Contributor

osallou commented Jun 29, 2018

No guidance2/2.02/test-cmds.txt (test file) present, skipping tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants