Skip to content

Comments

add bwa 0.7.17#373

Merged
osallou merged 3 commits intoBioContainers:masterfrom
ychenbioinfo:update/bwa
May 29, 2020
Merged

add bwa 0.7.17#373
osallou merged 3 commits intoBioContainers:masterfrom
ychenbioinfo:update/bwa

Conversation

@ychenbioinfo
Copy link
Contributor

add version

@biocontainers-bot
Copy link
Collaborator

Found an existing bioconda package for this software (https://bioconda.github.io/recipes/bwa/README.html), is this the same, then you should update the recipe in bioconda to avoid duplicates.


################## METADATA ######################
LABEL base_image="biocontainers:v1.1.0_cv2"
LABEL version = "5"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no space between label and value (version=5)

by the way, should be version 1 as it is first version of the release

version is internal counter, not related to tool release. You only increase it (default to be set to 1) when modifying the Dockerfile for the same tool release

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Okay, thanks for pointing it out. I thought the version is used to track how many updates you have for the software.

@biocontainers-bot
Copy link
Collaborator

Found an existing bioconda package for this software (https://bioconda.github.io/recipes/bwa/README.html), is this the same, then you should update the recipe in bioconda to avoid duplicates.

@biocontainers-bot
Copy link
Collaborator

No bwa/0.7.17/test-cmds.txt (test file) present, skipping tests

@osallou osallou merged commit 9972d8f into BioContainers:master May 29, 2020
@biocontainers-bot
Copy link
Collaborator

Found an existing bioconda package for this software (https://bioconda.github.io/recipes/bwa/README.html), is this the same, then you should update the recipe in bioconda to avoid duplicates.

@biocontainers-bot
Copy link
Collaborator

No bwa/0.7.17/test-cmds.txt (test file) present, skipping tests

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants