Adding a working container for NanoSV#397
Conversation
|
can't modify multiple containers in a same pull request |
2 similar comments
|
can't modify multiple containers in a same pull request |
|
can't modify multiple containers in a same pull request |
|
oops -- accidentally committed a vim swapfile. Should be good now. |
|
No biotools label defined, please check if tool is not already defined in biotools (https://bio.tools) and add extra.identifiers.biotools label if it exists. If it is not defined, you can ignore this comment. |
|
Found an existing bioconda package for this software (https://bioconda.github.io/recipes/nanosv/README.html), is this the same, then you should update the recipe in bioconda to avoid duplicates. |
|
PS: this software is basically abandonware. I am not the software maintainer. I just want Biocontainers to contain a version of it that's actually, well, contained. |
|
No nanosv/1.2.4/test-cmds.txt (test file) present, skipping tests |
nanosv/1.2.4/Dockerfile
Outdated
| LABEL software.version="1.2.4" | ||
| LABEL about.summary="NanoSV is a software package that can be used to identify structural genomic variations in long-read sequencing data" | ||
| LABEL about.home="https://github.com/mroosmalen/nanosv" | ||
| LABEL about.documentation="https://github.com/BioContainers/specs/wiki" |
There was a problem hiding this comment.
This biocontainers doc page ;-) should siftware doc page, if any, else put homepage
|
Thanks for contrib. There is just a small update to be done before merge |
|
No biotools label defined, please check if tool is not already defined in biotools (https://bio.tools) and add extra.identifiers.biotools label if it exists. If it is not defined, you can ignore this comment. |
|
Found an existing bioconda package for this software (https://bioconda.github.io/recipes/nanosv/README.html), is this the same, then you should update the recipe in bioconda to avoid duplicates. |
|
No worries! And I've fixed that. To be honest the sum-total of the documentation is the readme.md on the Github repo. Hopefully it should be good to go! |
|
No nanosv/1.2.4/test-cmds.txt (test file) present, skipping tests |
|
No biotools label defined, please check if tool is not already defined in biotools (https://bio.tools) and add extra.identifiers.biotools label if it exists. If it is not defined, you can ignore this comment. |
|
Found an existing bioconda package for this software (https://bioconda.github.io/recipes/nanosv/README.html), is this the same, then you should update the recipe in bioconda to avoid duplicates. |
|
No nanosv/1.2.4/test-cmds.txt (test file) present, skipping tests |
3 participants
Submitting a Container
(If you're requesting for a new container, please check the procedure described here.
Check BioContainers' Dockerfile specifications
Checklist
Check BioContainers' Dockerfile metadata
As noted above, while this is available as an autobuild from BioConda, the tool itself actually depends on sambamba, but that dependency is not listed in the BioConda package. The result is that the autobuilt container is not self-contained. This container adds sambamba, so that it is now self-contained. The python version had to be specified due to some dependency issues (see mroosmalen/nanosv#65).