Skip to content

Comments

Create Dockerfile#473

Merged
osallou merged 10 commits intoBioContainers:masterfrom
JosephLaiC:master
Sep 15, 2022
Merged

Create Dockerfile#473
osallou merged 10 commits intoBioContainers:masterfrom
JosephLaiC:master

Conversation

@JosephLaiC
Copy link
Contributor

@JosephLaiC JosephLaiC commented Sep 14, 2022

After struggling with build mace with bioconda or manually build with biocontainer, create mace dockerfile based on the centos7.

Submitting a Container

(If you're requesting for a new container, please check the procedure described here.

Check BioContainers' Dockerfile specifications

Checklist

  1. Misc
  • My tool doesn't exist in BioConda
  • The image can be built
  1. Metadata
  • LABEL base_image
  • LABEL version
  • LABEL software.version
  • LABEL about.summary
  • LABEL about.home
  • LABEL about.license
  • MAINTAINER
  1. Extra (optionals)
  • I have written tests in test-cmds.txt
  • LABEL extra.identifier
  • LABEL about.documentation
  • LABEL about.license_file
  • LABEL about.tags

Check BioContainers' Dockerfile metadata

Other message:
After convert quay.io/biocontainers/mace to singularity sif, couldn't bind directory with error:
/etc/resolv.conf doesn't exist in container

while run "conda install -c bioconda mace" showed error:

  • mace -> gsl >=2.5,<2.6.0a0
  • mace -> python_abi 2.7.* *_cp27mu

I've checked this version of docker could work in singularity with volume binding.

After struggling with build mace with bioconda or manually build with biocontainer, create mace dockerfile based on the centos7.
Just found simply type "conda install -c conda-forge -c bioconda mace==1.2" according to the information on https://biocontainers.pro/tools/mace
Copy link
Contributor

@osallou osallou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be in a subdir with upstream version name

mace/Dockerfile Outdated
################## METADATA ######################

LABEL base_image="biocontainers:v1.0.0_cv4"
LABEL version="3"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

First release of dockerfile so should be 1

@osallou
Copy link
Contributor

osallou commented Sep 15, 2022

Should be in a subdir with upstream version name

you misunderstood me, must be in softwarename/softwareversion/Dockerfile

in your case:

mace/1.2/Dockerfile

and software.name should be mace (lowercase)

@JosephLaiC
Copy link
Contributor Author

Just a new guy in github. lol

@biocontainers-bot
Copy link
Collaborator

about.license field is a URL. license should be the license identifier (GPL-3.0 for example).

@biocontainers-bot
Copy link
Collaborator

about.license field is not in spdx list: https://spdx.org/licenses/, if it is a typo error, please fix it. If this is not a standard license, please specify Custom License and use about.license_file label to specify license location (in container or url).

@biocontainers-bot
Copy link
Collaborator

Found a biotools entry matching the software name (https://bio.tools/MACE), if this is the same software, please add the extra.identifiers.biotools label to your Dockerfile

@biocontainers-bot
Copy link
Collaborator

No test-cmds.txt (test file) present, skipping tests

@osallou
Copy link
Contributor

osallou commented Sep 15, 2022

as suggested, license field should be spdx compliant ie

GPL-3.0-or-later or GPL-3.0-only (depends on soft license)

and should see if biotools entry match this software to add related metadata label

@JosephLaiC
Copy link
Contributor Author

should see if biotools entry match this software to add related metadata label

MACE on biotools is "MACE - Mass Spectra for Chemical Ecology".

This software is "MACE - Model base Analysis of ChIP-Exo".

@biocontainers-bot
Copy link
Collaborator

Found a biotools entry matching the software name (https://bio.tools/MACE), if this is the same software, please add the extra.identifiers.biotools label to your Dockerfile

@biocontainers-bot
Copy link
Collaborator

No test-cmds.txt (test file) present, skipping tests

@osallou osallou merged commit f329b21 into BioContainers:master Sep 15, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants