Skip to content

feat(wrapperModules.niri): option for auto translated repeated values#473

Merged
BirdeeHub merged 2 commits into
mainfrom
niri
Apr 28, 2026
Merged

feat(wrapperModules.niri): option for auto translated repeated values#473
BirdeeHub merged 2 commits into
mainfrom
niri

Conversation

@BirdeeHub

Copy link
Copy Markdown
Owner

@BirdeeHub BirdeeHub force-pushed the niri branch 7 times, most recently from 25c7402 to a42dd5e Compare April 28, 2026 18:17
@patwid

patwid commented Apr 28, 2026

Copy link
Copy Markdown
Contributor

I think the include option is similar to spawn-at-startup et al. Maybe we could model include as a dedicated option as well?

Usage could look something like this maybe:

include = [
  "required-path" 
  { _: { props = { optional = true; }; content = "optional-path"; } 
];

@BirdeeHub

BirdeeHub commented Apr 28, 2026

Copy link
Copy Markdown
Owner Author

We can certainly still add includes like we did binds and stuff like that. We probably should.

However, we would have to keep doing that every time there was an option like that that gets added.

I would like to have both if possible? But if I had to pick 1, generic lets people easily map to that themselves? Whereas in extraConfig, they might end up calling toKdl themselves anyway, or ignoring it and doing some crazy string templating that could have been much simpler like this.

@BirdeeHub

BirdeeHub commented Apr 28, 2026

Copy link
Copy Markdown
Owner Author

Because with extraSettings it is

config.extraSettings = [
  { include = ./idk; }
  { include = [ { optional = true; } "~/impure/path" ]; }
];

Which, is honestly fairly close to the original with some extra punctuation.

@BirdeeHub BirdeeHub force-pushed the niri branch 4 times, most recently from 5f5c99b to 21a013f Compare April 28, 2026 19:54
@BirdeeHub

BirdeeHub commented Apr 28, 2026

Copy link
Copy Markdown
Owner Author

Im going to just go with it. I was thinking about putting it inside settings as settings.extra, but what it actually is, is a list of multiple OF the settings set.

So, it belongs at the same level, and it is literally "extra config.settings"

I also improved the doc examples. It was sanitizing functions.

@BirdeeHub BirdeeHub merged commit 2a16280 into main Apr 28, 2026
2 checks passed
@BirdeeHub BirdeeHub deleted the niri branch April 28, 2026 20:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants