Conversation
25c7402 to
a42dd5e
Compare
|
I think the include option is similar to spawn-at-startup et al. Maybe we could model include as a dedicated option as well? Usage could look something like this maybe: |
|
We can certainly still add However, we would have to keep doing that every time there was an option like that that gets added. I would like to have both if possible? But if I had to pick 1, generic lets people easily map to that themselves? Whereas in extraConfig, they might end up calling toKdl themselves anyway, or ignoring it and doing some crazy string templating that could have been much simpler like this. |
|
Because with extraSettings it is config.extraSettings = [
{ include = ./idk; }
{ include = [ { optional = true; } "~/impure/path" ]; }
];Which, is honestly fairly close to the original with some extra punctuation. |
5f5c99b to
21a013f
Compare
|
Im going to just go with it. I was thinking about putting it inside settings as settings.extra, but what it actually is, is a list of multiple OF the settings set. So, it belongs at the same level, and it is literally "extra I also improved the doc examples. It was sanitizing functions. |
#472 (comment)
@patwid thoughts?