Corrections to README#166
Merged
Merged
Conversation
jwong-1
approved these changes
Oct 20, 2020
jwong-1
left a comment
jwong-1
left a comment
Contributor
There was a problem hiding this comment.
Hmm, seems like I forgot to update the readme when I made --help command. Thanks Lauren.
aafshinfard
approved these changes
Apr 1, 2021
Collaborator
|
Now we can merge this after the CI fixes I am pushing |
Contributor
Author
|
@afshinfard - Just let me know when the CI fixes are pushed to master and I can rebase this branch on master |
aafshinfard
reviewed
Apr 1, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just found that the options to specify the technology-specific
mvalue usingprotocolisn't consistent between the makefile and the README