Ensure Wireguard endpoint is valid before trying to use it#1024
Merged
rkervella merged 1 commit intoBishopFox:masterfrom Dec 8, 2022
Merged
Ensure Wireguard endpoint is valid before trying to use it#1024rkervella merged 1 commit intoBishopFox:masterfrom
rkervella merged 1 commit intoBishopFox:masterfrom
Conversation
rkervella
approved these changes
Dec 6, 2022
Member
|
That will work to fix the crash, I wanted to look deeper into why the netstack IP was empty in the first place. I believe this is a result of a previous refactor on the key exchange but I haven't taken the time to investigate. |
Contributor
Author
It's not the most elegant but it works. I was stepping through the code and I think a bit more refactoring to separate the initial connect vs keyed connections is probably the proper fix but probably unnecessary unless something else pops up. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #931