Skip to content

Set column attribute SQL_DESC_TYPE_NAME - #103

Merged
justing-bq merged 1 commit into
apache-odbcfrom
colAttrTypeName
Sep 19, 2025
Merged

Set column attribute SQL_DESC_TYPE_NAME#103
justing-bq merged 1 commit into
apache-odbcfrom
colAttrTypeName

Conversation

@justing-bq

Copy link
Copy Markdown

Rationale for this change

SQLColAttribute on SQL_DESC_TYPE_NAME was returning an empty result.

What changes are included in this PR?

Now we determine our type name from the received type ID instead of the type name received from the server.

Are these changes tested?

Yes

Are there any user-facing changes?

Calling SQLColAttribute on SQL_DESC_TYPE_NAME should now work properly.

Comment thread cpp/src/arrow/flight/sql/odbc/tests/columns_test.cc Outdated
@justing-bq
justing-bq force-pushed the colAttrTypeName branch 2 times, most recently from b7deef5 to ad91796 Compare September 18, 2025 20:26

@alinaliBQ alinaliBQ left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@justing-bq
justing-bq merged commit b814163 into apache-odbc Sep 19, 2025
38 of 42 checks passed
@justing-bq
justing-bq deleted the colAttrTypeName branch September 19, 2025 16:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants