Remove RUN_ALL_TESTS as they are not needed - #107
Merged
Conversation
alinaliBQ
marked this pull request as ready for review
September 24, 2025 17:20
justing-bq
approved these changes
Sep 24, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously, tests on Windows were not being run due to apache#47434. So we added
RUN_ALL_TESTSas a workaround in early May, before apache#47434 was raised.Now that apache#47434 is resolved, we can remove
RUN_ALL_TESTSas they are not needed.Other changes:
arrow_odbc_spi_impl_testtoodbc_spi_impl_testso the test executable will bearrow_odbc_spi_impl_test.exeinstead ofarrow_arrow_odbc_spi_impl_test.exe