Fix test assertions - #121
Merged
Merged
Conversation
alinaliBQ
reviewed
Oct 15, 2025
justing-bq
force-pushed
the
fixAssertions
branch
from
October 16, 2025 00:35
162cc9f to
72e70b5
Compare
justing-bq
force-pushed
the
fixAssertions
branch
from
October 16, 2025 00:49
72e70b5 to
0fe140d
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
Many of the test assertions are of the form
EXPECT_which allows the test to continue even after failing the assertion. Updating this toASSERT_causes the test to stop immediately after failing the assertion.What changes are included in this PR?
Updated
EXPECT_toASSERT_where appropriate.Placed ODBC calls directly in assertion instead of asserting on a return code.
Are these changes tested?
Yes
Are there any user-facing changes?
No.