Define New Base Test Fixtures - #128
Merged
Merged
Conversation
justing-bq
force-pushed
the
odbcTestBase
branch
from
October 27, 2025 17:23
eb891d9 to
a1e68ce
Compare
This was referenced Oct 27, 2025
justing-bq
force-pushed
the
odbcTestBase
branch
from
October 27, 2025 21:05
a1e68ce to
e3b7c4a
Compare
|
I see there is test failure, after it is resolved, we can merge this PR |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rationale for this change
There are several tests that require
SetUp/Teardownwithout the driver connecting/disconnecting. This restructure of the test fixtures handles this problem.What changes are included in this PR?
New base classes added for
ODBCRemoteTestBase,ODBCMockTestBase, andODBCTestBase. Other test fixtures now inherit from these base test fixture classes.Are these changes tested?
Yes
Are there any user-facing changes?
No.