Skip to content

Implement SQLTables - #65

Merged
rscales merged 10 commits into
apache-odbcfrom
sql-tables
Jul 25, 2025
Merged

Implement SQLTables#65
rscales merged 10 commits into
apache-odbcfrom
sql-tables

Conversation

@rscales

@rscales rscales commented Jul 16, 2025

Copy link
Copy Markdown

Implement SQLTables

@rscales
rscales marked this pull request as draft July 16, 2025 02:22
Comment thread cpp/src/arrow/flight/sql/odbc/entry_points.cc Outdated
Comment thread cpp/src/arrow/flight/sql/odbc/odbc_api.cc Outdated
Comment thread cpp/src/arrow/flight/sql/odbc/tests/odbc_test_suite.h
Comment thread cpp/src/arrow/flight/sql/odbc/tests/tables_test.cc Outdated
Comment thread cpp/src/arrow/flight/sql/odbc/tests/tables_test.cc
Comment thread cpp/src/arrow/flight/sql/odbc/tests/tables_test.cc Outdated
Comment thread cpp/src/arrow/flight/sql/odbc/tests/tables_test.cc Outdated
Comment thread cpp/src/arrow/flight/sql/odbc/tests/tables_test.cc Outdated
Comment thread cpp/src/arrow/flight/sql/odbc/tests/tables_test.cc Outdated
@rscales
rscales marked this pull request as ready for review July 23, 2025 16:21
Comment thread cpp/src/arrow/flight/sql/odbc/tests/tables_test.cc
Comment thread cpp/src/arrow/flight/sql/odbc/tests/tables_test.cc Outdated

@alinaliBQ alinaliBQ left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After addressing the comments, let's also run the CI to ensure they pass

@alinaliBQ alinaliBQ left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@rscales
rscales merged commit 50c190d into apache-odbc Jul 25, 2025
24 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants