CT-364: Convert Wallet and Wallets to ES6 class and improve type support#389
Merged
Conversation
tylerlevine
commented
Jun 20, 2019
Contributor
- Refactor example keycard code into separate file
- Introduce and begin using standard callback type
- Fix inconsistent error behavior in some methods
Codecov Report
@@ Coverage Diff @@
## master #389 +/- ##
==========================================
+ Coverage 38.41% 60.52% +22.1%
==========================================
Files 70 72 +2
Lines 9644 9689 +45
Branches 2092 2122 +30
==========================================
+ Hits 3705 5864 +2159
+ Misses 5324 2897 -2427
- Partials 615 928 +313
Continue to review full report at Codecov.
|
dannydeezy
reviewed
Jun 20, 2019
Contributor
There was a problem hiding this comment.
Is this an entirely new file, or was it copied from somewhere else?
Contributor
Author
There was a problem hiding this comment.
It's a new file, but the code was extracted out of wallet.ts
596b4e4 to
be9384d
Compare
dannydeezy
approved these changes
Jun 21, 2019
Contributor
|
reviewed in person with tyler, looks good! |
This was referenced Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.