Skip to content

CT-364: Convert Wallet and Wallets to ES6 class and improve type support#389

Merged
tylerlevine merged 2 commits into
masterfrom
CT-364-typescriptify-wallets
Jun 21, 2019
Merged

CT-364: Convert Wallet and Wallets to ES6 class and improve type support#389
tylerlevine merged 2 commits into
masterfrom
CT-364-typescriptify-wallets

Conversation

@tylerlevine

Copy link
Copy Markdown
Contributor
  • Refactor example keycard code into separate file
  • Introduce and begin using standard callback type
  • Fix inconsistent error behavior in some methods

@tylerlevine tylerlevine requested a review from dannydeezy as a code owner June 20, 2019 03:18
@codecov

codecov Bot commented Jun 20, 2019

Copy link
Copy Markdown

Codecov Report

Merging #389 into master will increase coverage by 22.1%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #389      +/-   ##
==========================================
+ Coverage   38.41%   60.52%   +22.1%     
==========================================
  Files          70       72       +2     
  Lines        9644     9689      +45     
  Branches     2092     2122      +30     
==========================================
+ Hits         3705     5864    +2159     
+ Misses       5324     2897    -2427     
- Partials      615      928     +313
Flag Coverage Δ
#integration 38.4% <ø> (-0.02%) ⬇️
#unit 54.35% <ø> (?)
Impacted Files Coverage Δ
src/v2/keycard.ts 2.75% <0%> (ø)
src/v2/trading/trade.ts 100% <0%> (ø)
src/v2/coins/bsv.ts 35.06% <0%> (+1.29%) ⬆️
src/keychains.ts 34% <0%> (+1.33%) ⬆️
src/util.ts 64.78% <0%> (+1.4%) ⬆️
src/v2/coinFactory.ts 94.62% <0%> (+2.15%) ⬆️
src/v2/coins/token.ts 71.52% <0%> (+2.64%) ⬆️
src/v2/coins/tbch.ts 78.57% <0%> (+3.57%) ⬆️
src/v2/coins/txlm.ts 78.57% <0%> (+3.57%) ⬆️
src/index.ts 96% <0%> (+4%) ⬆️
... and 43 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9530bad...be9384d. Read the comment docs.

Comment thread modules/core/src/v2/keycard.ts Outdated

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this an entirely new file, or was it copied from somewhere else?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's a new file, but the code was extracted out of wallet.ts

@tylerlevine tylerlevine force-pushed the CT-364-typescriptify-wallets branch from 596b4e4 to be9384d Compare June 21, 2019 05:45
@dannydeezy

Copy link
Copy Markdown
Contributor

reviewed in person with tyler, looks good!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants