fix(root): replace elliptic with noble/secp256k1 #5577
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alebusse
force-pushed
the
WP-3704
branch
2 times, most recently
from
90d3ed9 to
cc7fede
Compare
Author
|
Don't merge until every involved team review and approved the pr (excluding Custody Experience) |
OttoAllmendinger
previously approved these changes
Feb 18, 2025
margueriteblair
previously approved these changes
Feb 18, 2025
|
It is suggested to use noble-curves or esm-only v2.x. If you can't, v1.7.1 is newer than 1.6. curves api is very similar to noble-secp256k1. |
alebusse
dismissed stale reviews from margueriteblair and OttoAllmendinger
via
4bba900
alebusse
force-pushed
the
WP-3704
branch
3 times, most recently
from
0f25d77 to
862d95a
Compare
OttoAllmendinger
approved these changes
Feb 20, 2025
DinshawKothari
approved these changes
Feb 20, 2025
margueriteblair
approved these changes
Feb 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
replace elliptic lib with noble/secp256k1
WP-3704
TICKET: WP-3704