feat(fiat): add aed and sgd #5780
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
drew-bitgo
force-pushed
the
FIAT-176
branch
3 times, most recently
from
9cd5919 to
08a644d
Compare
TICKET: FIAT-176 Add United Arab Emirates Dirham and Singapore Dollar
Contributor
|
sorry I mispress the button |
zahin-mohammad
approved these changes
Mar 17, 2025
| VerifyTransactionOptions, | ||
| } from '../'; | ||
|
|
||
| export class FiatAED extends BaseCoin { |
Contributor
There was a problem hiding this comment.
Would it be easier to just create a new package for the fiat coins, abstract-fiat? And then each of these fiat coins can extend a common FiatBaseCoin class.
Contributor
Author
There was a problem hiding this comment.
probably yes. I will create a ticket and look into this. We will be adding a lot more fiats in the future, but these two (and eur and gbp) are the only ones we will need for H1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TICKET: FIAT-176
Add United Arab Emirates Dirham and Singapore Dollar