-
Notifications
You must be signed in to change notification settings - Fork 299
feat(fiat): add aed and sgd #5780
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,76 @@ | ||
| /** | ||
| * @prettier | ||
| */ | ||
| import { | ||
| BaseCoin, | ||
| BitGoBase, | ||
| KeyPair, | ||
| MethodNotImplementedError, | ||
| ParsedTransaction, | ||
| ParseTransactionOptions, | ||
| SignedTransaction, | ||
| SignTransactionOptions, | ||
| VerifyAddressOptions, | ||
| VerifyTransactionOptions, | ||
| } from '../'; | ||
|
|
||
| export class FiatAED extends BaseCoin { | ||
| static createInstance(bitgo: BitGoBase): BaseCoin { | ||
| return new FiatAED(bitgo); | ||
| } | ||
|
|
||
| /** | ||
| * Returns the factor between the base unit and its smallest subdivison | ||
| * @return {number} | ||
| */ | ||
| getBaseFactor() { | ||
| return 1e2; | ||
| } | ||
|
|
||
| getChain() { | ||
| return 'fiataed'; | ||
| } | ||
|
|
||
| getFamily() { | ||
| return 'fiat'; | ||
| } | ||
|
|
||
| getFullName() { | ||
| return 'United Arab Emirates Dirham'; | ||
| } | ||
|
|
||
| /** | ||
| * Return whether the given m of n wallet signers/ key amounts are valid for the coin | ||
| */ | ||
| isValidMofNSetup({ m, n }: { m: number; n: number }) { | ||
| return m === 0 && n === 0; | ||
| } | ||
|
|
||
| isValidAddress(address: string): boolean { | ||
| throw new MethodNotImplementedError(); | ||
| } | ||
|
|
||
| generateKeyPair(seed?: Buffer): KeyPair { | ||
| throw new MethodNotImplementedError(); | ||
| } | ||
|
|
||
| isValidPub(pub: string): boolean { | ||
| throw new MethodNotImplementedError(); | ||
| } | ||
|
|
||
| async parseTransaction(params: ParseTransactionOptions): Promise<ParsedTransaction> { | ||
| return {}; | ||
| } | ||
|
|
||
| async isWalletAddress(params: VerifyAddressOptions): Promise<boolean> { | ||
| throw new MethodNotImplementedError(); | ||
| } | ||
|
|
||
| async verifyTransaction(params: VerifyTransactionOptions): Promise<boolean> { | ||
| return true; | ||
| } | ||
|
|
||
| async signTransaction(params: SignTransactionOptions = {}): Promise<SignedTransaction> { | ||
| throw new MethodNotImplementedError(); | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,76 @@ | ||
| /** | ||
| * @prettier | ||
| */ | ||
| import { | ||
| BaseCoin, | ||
| BitGoBase, | ||
| KeyPair, | ||
| MethodNotImplementedError, | ||
| ParsedTransaction, | ||
| ParseTransactionOptions, | ||
| SignedTransaction, | ||
| SignTransactionOptions, | ||
| VerifyAddressOptions, | ||
| VerifyTransactionOptions, | ||
| } from '..'; | ||
|
|
||
| export class FiatSGD extends BaseCoin { | ||
| static createInstance(bitgo: BitGoBase): BaseCoin { | ||
| return new FiatSGD(bitgo); | ||
| } | ||
|
|
||
| /** | ||
| * Returns the factor between the base unit and its smallest subdivison | ||
| * @return {number} | ||
| */ | ||
| getBaseFactor() { | ||
| return 1e2; | ||
| } | ||
|
|
||
| getChain() { | ||
| return 'fiatsgd'; | ||
| } | ||
|
|
||
| getFamily() { | ||
| return 'fiat'; | ||
| } | ||
|
|
||
| getFullName() { | ||
| return 'Singapore Dollar'; | ||
| } | ||
|
|
||
| /** | ||
| * Return whether the given m of n wallet signers/ key amounts are valid for the coin | ||
| */ | ||
| isValidMofNSetup({ m, n }: { m: number; n: number }) { | ||
| return m === 0 && n === 0; | ||
| } | ||
|
|
||
| isValidAddress(address: string): boolean { | ||
| throw new MethodNotImplementedError(); | ||
| } | ||
|
|
||
| generateKeyPair(seed?: Buffer): KeyPair { | ||
| throw new MethodNotImplementedError(); | ||
| } | ||
|
|
||
| isValidPub(pub: string): boolean { | ||
| throw new MethodNotImplementedError(); | ||
| } | ||
|
|
||
| async parseTransaction(params: ParseTransactionOptions): Promise<ParsedTransaction> { | ||
| return {}; | ||
| } | ||
|
|
||
| async isWalletAddress(params: VerifyAddressOptions): Promise<boolean> { | ||
| throw new MethodNotImplementedError(); | ||
| } | ||
|
|
||
| async verifyTransaction(params: VerifyTransactionOptions): Promise<boolean> { | ||
| return true; | ||
| } | ||
|
|
||
| async signTransaction(params: SignTransactionOptions = {}): Promise<SignedTransaction> { | ||
| throw new MethodNotImplementedError(); | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| /** | ||
| * @prettier | ||
| */ | ||
| import { BaseCoin, BitGoBase } from '../'; | ||
| import { FiatAED } from './fiataed'; | ||
|
|
||
| export class TfiatAED extends FiatAED { | ||
| static createInstance(bitgo: BitGoBase): BaseCoin { | ||
| return new TfiatAED(bitgo); | ||
| } | ||
|
|
||
| getChain() { | ||
| return 'tfiataed'; | ||
| } | ||
|
|
||
| getFullName() { | ||
| return 'Testnet United Arab Emirates Dirham'; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,19 @@ | ||
| /** | ||
| * @prettier | ||
| */ | ||
| import { BaseCoin, BitGoBase } from '../'; | ||
| import { FiatSGD } from './fiatsgd'; | ||
|
|
||
| export class TfiatSGD extends FiatSGD { | ||
| static createInstance(bitgo: BitGoBase): BaseCoin { | ||
| return new TfiatSGD(bitgo); | ||
| } | ||
|
|
||
| getChain() { | ||
| return 'tfiatsgd'; | ||
| } | ||
|
|
||
| getFullName() { | ||
| return 'Testnet Singapore Dollar'; | ||
| } | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would it be easier to just create a new package for the fiat coins,
abstract-fiat? And then each of these fiat coins can extend a common FiatBaseCoin class.There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
probably yes. I will create a ticket and look into this. We will be adding a lot more fiats in the future, but these two (and eur and gbp) are the only ones we will need for H1